Substitution of ToPascalCase logic with a more general one

[filippobottega]

Hi,
the ToPascalCase login is not able to manage cases like these:

• MY_FIRST_CLASS

• MY_PROPERTY

• ...
  For this reason I have changed the ToPascalCase logic using chviLadislav contribution found at how-can-i-convert-text-to-pascal-case.

  Please check the changes and pull the request if you like.

  Thank you and best regards,
  Filippo

[mganss]

Thanks. Can you check the failing unit tests?

[filippobottega]

Hi @mganss,
I have corrected some tests but TestNetex is too complex for me to let me solve the problem.
I suppose that the Generator is emitting a wrong code because some partial classes are inheriting from different classes because a number postfix on the base class. May be the Generator is not able to handle a this special case because of the new ToPascalCase function.
I have created a sample solution to understand the problem but is not possible for me to understand how to solve it in short time.
If you have any idea please drop me a line.

Thank you,
Filippo

ConsoleApp1.zip

[mganss]

The difference in class names revealed a name clash corner case. Should be fixed now.

[MeikelLP]

FYI this was a breaking change for us. We had types named TRG which are now named Trg which had us to adjust several source files + hours of debugging.

Please be aware of such changes in the future.

[filippobottega]

Hi @MeikelLP,
I agree with you about the fact that this change is a breaking one. The problem is the lack of a standard defining the behaviour of ToPascalCase functionality.
It might be more friendly to restore the old behaviour and implement a second way to change the names, but this will probably take more time.
I suggest changing the version number of the realease to indicate the breaking change.

Sorry for the inconvenience,
Filippo

[mganss]

@MeikelLP You're right, I'm sorry. Wondering if it makes sense to release a new major version now that the horse has bolted.

[MeikelLP]

I mean it wasn't very smart on our side to just use the "latest" in the first place however I think it's smarter for us to go with the "latest" than sticking to the "legacy"

@mganss I think a major or minor (2.1) may be valid here. This also gives you the opportunity to note breaking changes (on the release page?)

[mganss]

I've released 2.1.908.