Not-Null Arrays when using --nullableReferenceAttributes

[las-nsc]

When applying the latest release to our project, all of the NRT warnings were fixed except one. The difference for this is one was that the complex type was referenced rather than inline, and just changing that has removed the nullable attributes, however since it is also never null in the initial state, I thought this change should be made. There's no rush to complete this, and I think it may need some more thought.

Combine IsCollection, IsArray and IsList into IsEnumerable, and use for nullable attribute prevention.
Moved GetSet into GetAccessors to avoid nested ternary
Tidied up ModelBuilder by encapsulating common groups of property setters on PropertyModel, using IXmlSchemaNode.

[codecov]

Codecov Report

Merging #338 (ebe7649) into master (8204bee) will increase coverage by 0.05%.
The diff coverage is 97.35%.

@@            Coverage Diff             @@
##           master     #338      +/-   ##
==========================================
+ Coverage   95.53%   95.59%   +0.05%     
==========================================
  Files          19       20       +1     
  Lines        3044     2880     -164     
  Branches      465      445      -20     
==========================================
- Hits         2908     2753     -155     
+ Misses         78       71       -7     
+ Partials       58       56       -2     

Impacted Files	Coverage Δ
XmlSchemaClassGenerator/ModelBuilder.cs	98.03% <96.94%> (+0.34%)	⬆️
XmlSchemaClassGenerator/TypeModel.cs	96.79% <98.21%> (+0.19%)	⬆️
XmlSchemaClassGenerator/Extensions.cs	100.00% <100.00%> (ø)
XmlSchemaClassGenerator/IXmlSchemaNode.cs	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8204bee...ebe7649. Read the comment docs.

[mganss]

Can you revert this? Sonarcloud complains about the nested ternary operator and I think they have a point.

[mganss]

• IsArray determines whether we can apply the XmlArrayItemAttribute optimization where the intermediate sequence disappears.
• IsList signals that the element is an xs:list
• IsCollection simply means that the corresponding element has maxOccurs > 1 and therefore we're mapping to a C# collection

[las-nsc]

No idea why a test failed (they pass locally), and can't figure out how to retry...

[mganss]

Thanks for your hard work. Would love to merge this. Could you remove the remaining nested ternaries?

[mganss]

No idea why a test failed (they pass locally), and can't figure out how to retry...

You can click on the ❌ then Details to view the output from AppVeyor. Manual retry doesn't seem to possible unless you're the owner.

[Nintynuts]

(This is my personal account)

I'm unable to make changes to the PR for 2 weeks. If there are particular ternary statements you want to revert, then go ahead, but personally I think if they're properly chained and formatted, then they're pretty clear and shouldn't be a problem. E.g.

return conditionA ? valueA
    : conditionB ? valueB
    : valueC;