Add DataReport chunking

README.md

@@ -10,10 +10,10 @@ Matter is a new secure / reliable / local / standard protocol for smart devices
 To know more about Matter: https://csa-iot.org/all-solutions/matter/
 
 node-matter is compatible with (or will soon be):
-- *iOS 16.2 - Home app*: fully working, [screenshot](https://github.com/mfucci/node-matter/issues/103#issuecomment-1374301293)
-- *Alexa*: fully working, [screenshot](https://github.com/mfucci/node-matter/issues/159#issuecomment-1374323476)
-- *Android - Home app*: nearly working, [thread](https://github.com/mfucci/node-matter/issues/140)
-- *Home Assistant*: was working, we are on it, [thread](https://github.com/mfucci/node-matter/issues/11)
+- **iOS - Home app**: fully working, [screenshot](https://github.com/mfucci/node-matter/issues/103#issuecomment-1374301293)
+- **Android - Home app**: fully working, [thread](https://github.com/mfucci/node-matter/issues/140#issuecomment-1374417228)
+- **Alexa**: fully working, [screenshot](https://github.com/mfucci/node-matter/issues/159#issuecomment-1374323476)
+- **Home Assistant**: was working, we are on it, [thread](https://github.com/mfucci/node-matter/issues/11)
 
 ## Installation
 

src/matter/interaction/InteractionMessages.ts

@@ -56,20 +56,23 @@ export const TlvReadRequest = TlvObject({
     interactionModelRevision: TlvField(0xFF, TlvUInt8),
 });
 
+export const TlvAttributeReport = TlvObject({
+    value: TlvField(1, TlvObject({
+        version: TlvField(0, TlvUInt32),
+        path: TlvField(1, TlvList({
+            endpointId: TlvField(2, TlvUInt16),
+            clusterId: TlvField(3, TlvUInt32),
+            id: TlvField(4, TlvUInt32),
+        })),
+        value: TlvField(2, TlvAny),
+    })),
+});
+
 export const TlvDataReport = TlvObject({
     subscriptionId: TlvOptionalField(0, TlvUInt32),
-    values: TlvField(1, TlvArray(TlvObject({
-        value: TlvField(1, TlvObject({
-            version: TlvField(0, TlvUInt32),
-            path: TlvField(1, TlvList({
-                endpointId: TlvField(2, TlvUInt16),
-                clusterId: TlvField(3, TlvUInt32),
-                id: TlvField(4, TlvUInt32),
-            })),
-            value: TlvField(2, TlvAny),
-        })),
-    }))),
-    isFabricFiltered: TlvOptionalField(4,  TlvBoolean),
+    values: TlvField(1, TlvArray(TlvAttributeReport)),
+    moreChunkedMessages: TlvOptionalField(3, TlvBoolean),
+    suppressResponse: TlvOptionalField(4, TlvBoolean),
     interactionModelRevision: TlvField(0xFF, TlvUInt8),
 });
 

src/matter/interaction/InteractionMessenger.ts

@@ -8,7 +8,7 @@ import { Logger } from "../../log/Logger";
 import { MessageExchange } from "../common/MessageExchange";
 import { MatterController } from "../MatterController";
 import { MatterDevice } from "../MatterDevice";
-import { TlvInvokeRequest, TlvInvokeResponse, TlvReadRequest, TlvDataReport, TlvSubscribeRequest, TlvSubscribeResponse, StatusCode, TlvStatusResponse, TlvTimedRequest } from "./InteractionMessages";
+import { TlvInvokeRequest, TlvInvokeResponse, TlvReadRequest, TlvDataReport, TlvSubscribeRequest, TlvSubscribeResponse, StatusCode, TlvStatusResponse, TlvTimedRequest, TlvAttributeReport } from "./InteractionMessages";
 import { ByteArray, TlvSchema, TypeFromSchema } from "@project-chip/matter.js";
 
 export const enum MessageType {
@@ -32,6 +32,8 @@ export type InvokeRequest = TypeFromSchema<typeof TlvInvokeRequest>;
 export type InvokeResponse = TypeFromSchema<typeof TlvInvokeResponse>;
 export type TimedRequest = TypeFromSchema<typeof TlvTimedRequest>;
 
+const MAX_SPDU_LENGTH = 1024;
+
 const logger = Logger.get("InteractionMessenger");
 
 class InteractionMessenger<ContextT> {
@@ -124,6 +126,36 @@ export class InteractionServerMessenger extends InteractionMessenger<MatterDevic
     }
 
     async sendDataReport(dataReport: DataReport) {
+        const messageBytes = TlvDataReport.encode(dataReport);
+        if (messageBytes.length > MAX_SPDU_LENGTH) {
+            // DataReport is too long, it needs to be sent in chunked
+            const attributeReportsToSend = [...dataReport.values];
+            dataReport.values.length = 0;
+            dataReport.moreChunkedMessages = true;
+
+            const emptyDataReportBytes = TlvDataReport.encode(dataReport);
+
+            let messageSize = emptyDataReportBytes.length;
+            while (true) {
+                const attributeReport = attributeReportsToSend.pop();
+                if (attributeReport === undefined) {
+                    // No more chunks to send
+                    dataReport.moreChunkedMessages = undefined;
+                    break;
+                }
+                const attributeReportBytes = TlvAttributeReport.encode(attributeReport).length;
+                if (messageSize + attributeReportBytes > MAX_SPDU_LENGTH) {
+                    // Report doesn't fit, sending this chunk
+                    await this.exchange.send(MessageType.ReportData, TlvDataReport.encode(dataReport));
+                    await this.waitForSuccess();
+                    dataReport.values.length = 0;
+                    messageSize = emptyDataReportBytes.length;
+                }
+                messageSize += attributeReportBytes;
+                dataReport.values.push(attributeReport);
+            }
+        }
+
         await this.exchange.send(MessageType.ReportData, TlvDataReport.encode(dataReport));
     }
 }

src/matter/interaction/InteractionServer.ts

@@ -151,7 +151,6 @@ export class InteractionServer implements ProtocolHandler<MatterDevice> {
             });
 
         return {
-            isFabricFiltered: true,
             interactionModelRevision: 1,
             values: values.map(({ path, value, version, schema }) => ({
                 value: {
@@ -179,12 +178,6 @@ export class InteractionServer implements ProtocolHandler<MatterDevice> {
             logger.debug(`Subscribe to ${attributeRequests.map(path => this.resolveAttributeName(path)).join(", ")}`);
             let attributes = this.getAttributes(attributeRequests);
 
-            // Temporay hack until attribution subscription is handled correctly
-            if (attributes.length > 1) {
-                // If subscription to multiple attributes is requested, only returns the onoff attribute to handle */*/* subscription.
-                attributes = [{ path: { endpointId: 1, clusterId: 6, id: 0 }, attribute: this.attributes.get("1/6/0") as AttributeServer<any>}];
-            }
-
             if (attributeRequests.length === 0) throw new Error("Invalid subscription request");
             if (minIntervalFloorSeconds < 0) throw new Error("minIntervalFloorSeconds should be greater or equal to 0");
             if (maxIntervalCeilingSeconds < 0) throw new Error("maxIntervalCeilingSeconds should be greater or equal to 1");

test/matter/interaction/InteractionProtocolTest.ts

@@ -29,7 +29,6 @@ const READ_REQUEST: ReadRequest = {
 
 const READ_RESPONSE: DataReport = {
     interactionModelRevision: 1,
-    isFabricFiltered: true,
     values: [
         { value: {
             path: {