Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No images load in browsers that don't support media queries #41

Closed
cbirdsong opened this issue Oct 30, 2019 · 5 comments
Closed

No images load in browsers that don't support media queries #41

cbirdsong opened this issue Oct 30, 2019 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@cbirdsong
Copy link

Found an error when doing some testing in IE9 - no images at all. From the look of things, it's because it doesn't support media queries, or specifically matchMedia:

SCRIPT438: Object doesn't support property or method 'matchMedia' 
loading-attribute-polyfill.min.js?ver=1.1.0, line 5 character 1942

I wouldn't expect a first-class lazyloading experience in such an old browser, but ideally images would err on the side of loading inefficiently instead of failing, just like older browsers without IntersectionObserver.

@mfranzke
Copy link
Owner

Couldn‘t agree more, valid point !!

@mfranzke mfranzke self-assigned this Nov 9, 2019
@mfranzke mfranzke added the bug Something isn't working label Nov 9, 2019
@mfranzke mfranzke closed this as completed Nov 9, 2019
@cbirdsong
Copy link
Author

Thanks!

@mfranzke
Copy link
Owner

mfranzke commented Nov 9, 2019

Sure, thank you for this finding. Have you positively retested this?

@cbirdsong
Copy link
Author

I haven’t – will check it out on Monday.

@mfranzke
Copy link
Owner

mfranzke commented Nov 9, 2019

Okay, no hassle. I‘ll even also make a npm release soon, so than it could get retested this way as well.

I did test it on a local Virtual Machine successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants