Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for symfony/console 6.0 #77

Merged
merged 2 commits into from
Dec 13, 2021
Merged

Added support for symfony/console 6.0 #77

merged 2 commits into from
Dec 13, 2021

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented Dec 10, 2021

Q A
Documentation no
Bugfix no
BC Break no
New Feature yes
RFC no
QA no

Description

This PR adds support for symfony/console 6, as it's a pretty popular component, and the update is pretty much backwards compatible.

composer.json Outdated Show resolved Hide resolved
@Ocramius Ocramius added the Enhancement New feature or request label Dec 11, 2021
@Ocramius Ocramius added this to the 3.6.0 milestone Dec 11, 2021
@Ocramius
Copy link
Member

Question: does this result in a downstream BC break, due to inheritance?

@acelaya
Copy link
Contributor Author

acelaya commented Dec 11, 2021

I think I don't follow. What do you mean?

@weierophinney
Copy link
Contributor

Question: does this result in a downstream BC break, due to inheritance?

It shouldn't. I've used symfony/console 6 with laminas-cli versions, and had no issues with commands. The issues will be if a user is writing commands that rely on portions of the symfony/console v4 API that are not present in later versions, or changed in later versions. Since they're very conservative about changing the inheritance API, in practice, I've not seen any cases where such breakage can occur.

@Ocramius Ocramius self-assigned this Dec 13, 2021
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

composer.lock still requires adjusting here

@Ocramius Ocramius removed their assignment Dec 13, 2021
@weierophinney weierophinney merged commit 36d38c7 into mezzio:3.6.x Dec 13, 2021
@acelaya acelaya deleted the feature/symfony-6 branch December 13, 2021 21:17
@weierophinney
Copy link
Contributor

@Ocramius I updated the composer.lock, but the fork was locked and I could not push back to it. Hoping that the branch builds correctly; if not, I'll open another PR with a patch to resolve.

(Bonus points: bumped to laminas-coding-standard 2.3, which means I could get rid of the "ignore-platform-reqs" flag!)

@acelaya
Copy link
Contributor Author

acelaya commented Dec 13, 2021

I was about to update the composer.lock, but I guess it's not needed anymore 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants