-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for symfony/console 6.0 #77
Conversation
Signed-off-by: Alejandro Celaya <[email protected]>
Question: does this result in a downstream BC break, due to inheritance? |
I think I don't follow. What do you mean? |
Signed-off-by: Alejandro Celaya <[email protected]>
It shouldn't. I've used symfony/console 6 with laminas-cli versions, and had no issues with commands. The issues will be if a user is writing commands that rely on portions of the symfony/console v4 API that are not present in later versions, or changed in later versions. Since they're very conservative about changing the inheritance API, in practice, I've not seen any cases where such breakage can occur. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
composer.lock
still requires adjusting here
@Ocramius I updated the (Bonus points: bumped to laminas-coding-standard 2.3, which means I could get rid of the "ignore-platform-reqs" flag!) |
I was about to update the composer.lock, but I guess it's not needed anymore 😅 |
Description
This PR adds support for symfony/console 6, as it's a pretty popular component, and the update is pretty much backwards compatible.