Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA fixes/improvements #10

Merged
merged 20 commits into from
Mar 19, 2020
Merged

QA fixes/improvements #10

merged 20 commits into from
Mar 19, 2020

Conversation

michalbundyra
Copy link
Member

Q A
QA yes

@michalbundyra
QA: Removes unused import
680d40f 
Signed-off-by: Michał Bundyra <[email protected]>
@michalbundyra
QA: Rename private static property (camelCase)
6b13253 
Signed-off-by: Michał Bundyra <[email protected]>
@michalbundyra
QA: Moves constant definition before properties (top of the class)
bb8248f 
Signed-off-by: Michał Bundyra <[email protected]>
@michalbundyra
QA: Adds missing strict type declarations
495cfff 
Signed-off-by: Michał Bundyra <[email protected]>
@michalbundyra
QA: Swaps yoda conditions
5e30c91 
Signed-off-by: Michał Bundyra <[email protected]>
@michalbundyra
QA: Imports internal PHP functions and constants
2d6fd30 
Signed-off-by: Michał Bundyra <[email protected]>
@michalbundyra
QA: Updates PHPUnit
123f4cc 
Signed-off-by: Michał Bundyra <[email protected]>
@michalbundyra
QA: Removes redundant bracket
256edf6 
Signed-off-by: Michał Bundyra <[email protected]>
@michalbundyra
QA: Adds missing space before RTH
b7b2267 
Signed-off-by: Michał Bundyra <[email protected]>
@michalbundyra
QA: Better assertions
984a09c 
Signed-off-by: Michał Bundyra <[email protected]>
@michalbundyra
QA: Fixes typo in test name
6fa5fd5 
Signed-off-by: Michał Bundyra <[email protected]>
@michalbundyra
QA: CamelCase variable names
b7731be 
Signed-off-by: Michał Bundyra <[email protected]>
@michalbundyra
QA: Signature updates in tests
d265e8a 
Signed-off-by: Michał Bundyra <[email protected]>
@michalbundyra
QA: Incrementation operator in for-loop in tests
0865de4 
Signed-off-by: Michał Bundyra <[email protected]>
@michalbundyra
QA: Adds missing trailing comma
cc013cc 
Signed-off-by: Michał Bundyra <[email protected]>
@michalbundyra
QA: Single quotes
1245f6b 
Signed-off-by: Michał Bundyra <[email protected]>
@michalbundyra
QA: PHPDocs updates
b4c78f4 
Signed-off-by: Michał Bundyra <[email protected]>
@michalbundyra
QA: Adds missing property in tests
dcae77a 
Signed-off-by: Michał Bundyra <[email protected]>
@michalbundyra michalbundyra added the Enhancement New feature or request label Mar 19, 2020
@michalbundyra michalbundyra added this to the 1.7.1 milestone Mar 19, 2020
froschdesign
froschdesign approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@froschdesign froschdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

michalbundyra added a commit that referenced this pull request Mar 19, 2020
@michalbundyra
Adds CHANGELOG entry for #10
ec6c91f
@michalbundyra michalbundyra merged commit d8c1267 into mezzio:master Mar 19, 2020
michalbundyra added a commit that referenced this pull request Mar 19, 2020
@michalbundyra
Merge branch 'qa/10' into develop
b0ae224 
Forward port #10
@michalbundyra michalbundyra deleted the qa-fixes branch March 19, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@froschdesign froschdesign froschdesign approved these changes

Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
1.7.1
Development

Successfully merging this pull request may close these issues.
2 participants
@michalbundyra @froschdesign