Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not report MA0134 when the ancestor operation is a discard operation #514

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

meziantou
Copy link
Owner

Fix #512

@meziantou meziantou marked this pull request as ready for review April 28, 2023 20:34
@meziantou meziantou enabled auto-merge (squash) April 28, 2023 20:35
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #514 (8bf80fa) into main (a616828) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #514   +/-   ##
=======================================
  Coverage   89.85%   89.85%           
=======================================
  Files         174      174           
  Lines       12786    12790    +4     
=======================================
+ Hits        11489    11493    +4     
  Misses       1297     1297           
Impacted Files Coverage Δ
.../Rules/AwaitAwaitableMethodInSyncMethodAnalyzer.cs 100.00% <100.00%> (ø)

@meziantou meziantou merged commit 32e47b4 into main Apr 28, 2023
@meziantou meziantou deleted the issues/512 branch April 28, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MA0134] False positive when using null conditional operator
1 participant