Merge pull request #270 from meysamhadeli/refactor/refactor-access-mo…

…difieres-in-feature-slices refactor: Refactor access modifiers in feature slices
meysamhadeli · Jul 16, 2023 · b4fd4d5 · b4fd4d5
2 parents 1262566 + 25230ee
commit b4fd4d5
Show file tree

Hide file tree

Showing 26 changed files with 41 additions and 47 deletions.
diff --git a/src/Services/Booking/src/Booking/Booking/Features/BookingMappings.cs b/src/Services/Booking/src/Booking/Booking/Features/BookingMappings.cs
@@ -3,7 +3,7 @@
 
 namespace Booking.Booking.Features;
 
-using CreatingBook.Commands.V1;
+using CreatingBook.V1;
 
 public class BookingMappings : IRegister
 {

diff --git a/...CreatingBook/Commands/V1/CreateBooking.cs → ...Features/CreatingBook/V1/CreateBooking.cs b/...CreatingBook/Commands/V1/CreateBooking.cs → ...Features/CreatingBook/V1/CreateBooking.cs
@@ -1,4 +1,4 @@
-namespace Booking.Booking.Features.CreatingBook.Commands.V1;
+namespace Booking.Booking.Features.CreatingBook.V1;
 
 using Ardalis.GuardClauses;
 using BuildingBlocks.Core;
@@ -8,7 +8,6 @@ namespace Booking.Booking.Features.CreatingBook.Commands.V1;
 using BuildingBlocks.EventStoreDB.Repository;
 using BuildingBlocks.Web;
 using Duende.IdentityServer.EntityFramework.Entities;
-using Elasticsearch.Net;
 using Exceptions;
 using Flight;
 using FluentValidation;
@@ -22,8 +21,7 @@ namespace Booking.Booking.Features.CreatingBook.Commands.V1;
 using Passenger;
 using ValueObjects;
 
-public record CreateBooking(Guid PassengerId, Guid FlightId, string Description) : ICommand<CreateBookingResult>,
-    IInternalCommand
+public record CreateBooking(Guid PassengerId, Guid FlightId, string Description) : ICommand<CreateBookingResult>
 {
     public Guid Id { get; init; } = NewId.NextGuid();
 }
@@ -66,7 +64,7 @@ public IEndpointRouteBuilder MapEndpoint(IEndpointRouteBuilder builder)
     }
 }
 
-internal class CreateBookingValidator : AbstractValidator<CreateBooking>
+public class CreateBookingValidator : AbstractValidator<CreateBooking>
 {
     public CreateBookingValidator()
     {

diff --git a/src/Services/Booking/src/Booking/Booking/Models/Booking.cs b/src/Services/Booking/src/Booking/Booking/Models/Booking.cs
@@ -2,7 +2,7 @@
 
 namespace Booking.Booking.Models;
 
-using Features.CreatingBook.Commands.V1;
+using Features.CreatingBook.V1;
 using ValueObjects;
 
 public record Booking : AggregateEventSourcing<Guid>

diff --git a/src/Services/Booking/src/Booking/BookingProjection.cs b/src/Services/Booking/src/Booking/BookingProjection.cs
@@ -7,7 +7,7 @@
 
 namespace Booking;
 
-using Booking.Features.CreatingBook.Commands.V1;
+using Booking.Features.CreatingBook.V1;
 using Booking.Models;
 using MassTransit;
 

diff --git a/src/Services/Booking/src/Booking/EventMapper.cs b/src/Services/Booking/src/Booking/EventMapper.cs
@@ -4,7 +4,7 @@
 
 namespace Booking;
 
-using Booking.Features.CreatingBook.Commands.V1;
+using Booking.Features.CreatingBook.V1;
 
 public sealed class EventMapper : IEventMapper
 {

diff --git a/src/Services/Booking/tests/IntegrationTest/Fakes/FakeCreateBookingCommand.cs b/src/Services/Booking/tests/IntegrationTest/Fakes/FakeCreateBookingCommand.cs
@@ -3,7 +3,7 @@
 namespace Integration.Test.Fakes;
 
 using System;
-using global::Booking.Booking.Features.CreatingBook.Commands.V1;
+using global::Booking.Booking.Features.CreatingBook.V1;
 using MassTransit;
 
 public sealed class FakeCreateBookingCommand : AutoFaker<CreateBooking>

diff --git a/src/Services/Flight/src/Flight/Aircrafts/Features/CreatingAircraft/V1/CreateAircraft.cs b/src/Services/Flight/src/Flight/Aircrafts/Features/CreatingAircraft/V1/CreateAircraft.cs
@@ -68,7 +68,7 @@ public IEndpointRouteBuilder MapEndpoint(IEndpointRouteBuilder builder)
     }
 }
 
-internal class CreateAircraftValidator : AbstractValidator<CreateAircraft>
+public class CreateAircraftValidator : AbstractValidator<CreateAircraft>
 {
     public CreateAircraftValidator()
     {

diff --git a/src/Services/Flight/src/Flight/Aircrafts/Features/CreatingAircraft/V1/CreateAircraftMongo.cs b/src/Services/Flight/src/Flight/Aircrafts/Features/CreatingAircraft/V1/CreateAircraftMongo.cs
@@ -17,7 +17,7 @@ namespace Flight.Aircrafts.Features.CreatingAircraft.V1;
 
 public record CreateAircraftMongo(Guid Id, string Name, string Model, int ManufacturingYear, bool IsDeleted = false) : InternalCommand;
 
-public class CreateAircraftMongoHandler : ICommandHandler<CreateAircraftMongo>
+internal class CreateAircraftMongoHandler : ICommandHandler<CreateAircraftMongo>
 {
     private readonly FlightReadDbContext _flightReadDbContext;
     private readonly IMapper _mapper;

diff --git a/src/Services/Flight/src/Flight/Airports/Features/CreatingAirport/V1/CreateAirport.cs b/src/Services/Flight/src/Flight/Airports/Features/CreatingAirport/V1/CreateAirport.cs
@@ -65,7 +65,7 @@ public IEndpointRouteBuilder MapEndpoint(IEndpointRouteBuilder builder)
     }
 }
 
-internal class CreateAirportValidator : AbstractValidator<CreateAirport>
+public class CreateAirportValidator : AbstractValidator<CreateAirport>
 {
     public CreateAirportValidator()
     {

diff --git a/src/Services/Flight/src/Flight/EventMapper.cs b/src/Services/Flight/src/Flight/EventMapper.cs
@@ -11,7 +11,7 @@ namespace Flight;
 using Flights.Features.DeletingFlight.V1;
 using Flights.Features.UpdatingFlight.V1;
 using Seats.Features.CreatingSeat.V1;
-using Seats.Features.ReservingSeat.Commands.V1;
+using Seats.Features.ReservingSeat.V1;
 
 // ref: https://www.ledjonbehluli.com/posts/domain_to_integration_event/
 public sealed class EventMapper : IEventMapper

diff --git a/src/Services/Flight/src/Flight/Flights/Features/DeletingFlight/V1/DeleteFlight.cs b/src/Services/Flight/src/Flight/Flights/Features/DeletingFlight/V1/DeleteFlight.cs
@@ -53,7 +53,7 @@ public IEndpointRouteBuilder MapEndpoint(IEndpointRouteBuilder builder)
     }
 }
 
-internal class DeleteFlightValidator : AbstractValidator<DeleteFlight>
+public class DeleteFlightValidator : AbstractValidator<DeleteFlight>
 {
     public DeleteFlightValidator()
     {

diff --git a/src/Services/Flight/src/Flight/Flights/Features/GettingFlightById/V1/GetFlightById.cs b/src/Services/Flight/src/Flight/Flights/Features/GettingFlightById/V1/GetFlightById.cs
@@ -61,7 +61,7 @@ public GetFlightByIdValidator()
     }
 }
 
-public class GetFlightByIdHandler : IQueryHandler<GetFlightById, GetFlightByIdResult>
+internal class GetFlightByIdHandler : IQueryHandler<GetFlightById, GetFlightByIdResult>
 {
     private readonly IMapper _mapper;
     private readonly FlightReadDbContext _flightReadDbContext;

diff --git a/src/Services/Flight/src/Flight/Flights/Features/UpdatingFlight/V1/UpdateFlight.cs b/src/Services/Flight/src/Flight/Flights/Features/UpdatingFlight/V1/UpdateFlight.cs
@@ -70,7 +70,7 @@ public IEndpointRouteBuilder MapEndpoint(IEndpointRouteBuilder builder)
     }
 }
 
-internal class UpdateFlightValidator : AbstractValidator<CreateFlight>
+public class UpdateFlightValidator : AbstractValidator<CreateFlight>
 {
     public UpdateFlightValidator()
     {

diff --git a/src/Services/Flight/src/Flight/GrpcServer/Services/FlightGrpcServices.cs b/src/Services/Flight/src/Flight/GrpcServer/Services/FlightGrpcServices.cs
@@ -8,7 +8,7 @@ namespace Flight.GrpcServer.Services;
 using System;
 using Flights.Features.GettingFlightById.V1;
 using Seats.Features.GettingAvailableSeats.V1;
-using Seats.Features.ReservingSeat.Commands.V1;
+using Seats.Features.ReservingSeat.V1;
 using GetAvailableSeatsResult = GetAvailableSeatsResult;
 using GetFlightByIdResult = GetFlightByIdResult;
 using ReserveSeatResult = ReserveSeatResult;

diff --git a/src/Services/Flight/src/Flight/Seats/Features/CreatingSeat/V1/CreateSeat.cs b/src/Services/Flight/src/Flight/Seats/Features/CreatingSeat/V1/CreateSeat.cs
@@ -1,17 +1,16 @@
 namespace Flight.Seats.Features.CreatingSeat.V1;
 
 using System;
-using System.Linq;
 using System.Threading;
 using System.Threading.Tasks;
 using Ardalis.GuardClauses;
 using BuildingBlocks.Core.CQRS;
 using BuildingBlocks.Core.Event;
 using BuildingBlocks.Web;
 using Duende.IdentityServer.EntityFramework.Entities;
-using Flight.Data;
-using Flight.Seats.Exceptions;
-using Flight.Seats.Models;
+using Data;
+using Exceptions;
+using Models;
 using Flights.ValueObjects;
 using FluentValidation;
 using Mapster;
@@ -71,7 +70,7 @@ private async Task<IResult> CreateSeat(CreateSeatRequestDto request, IMediator m
     }
 }
 
-internal class CreateSeatValidator : AbstractValidator<CreateSeat>
+public class CreateSeatValidator : AbstractValidator<CreateSeat>
 {
     public CreateSeatValidator()
     {

diff --git a/src/Services/Flight/src/Flight/Seats/Features/CreatingSeat/V1/CreateSeatMongo.cs b/src/Services/Flight/src/Flight/Seats/Features/CreatingSeat/V1/CreateSeatMongo.cs
@@ -6,9 +6,9 @@
 using Ardalis.GuardClauses;
 using BuildingBlocks.Core.CQRS;
 using BuildingBlocks.Core.Event;
-using Flight.Data;
-using Flight.Seats.Exceptions;
-using Flight.Seats.Models;
+using Data;
+using Exceptions;
+using Models;
 using MapsterMapper;
 using MediatR;
 using MongoDB.Driver;
@@ -17,7 +17,7 @@
 public record CreateSeatMongo(Guid Id, string SeatNumber, Enums.SeatType Type,
     Enums.SeatClass Class, Guid FlightId, bool IsDeleted = false) : InternalCommand;
 
-public class CreateSeatMongoHandler : ICommandHandler<CreateSeatMongo>
+internal class CreateSeatMongoHandler : ICommandHandler<CreateSeatMongo>
 {
     private readonly FlightReadDbContext _flightReadDbContext;
     private readonly IMapper _mapper;

diff --git a/src/Services/Flight/src/Flight/Seats/Features/GettingAvailableSeats/V1/GetAvailableSeats.cs b/src/Services/Flight/src/Flight/Seats/Features/GettingAvailableSeats/V1/GetAvailableSeats.cs
@@ -55,7 +55,7 @@ private async Task<IResult> GetAvailableSeats(Guid id, IMediator mediator, Cance
     }
 }
 
-internal class GetAvailableSeatsValidator : AbstractValidator<GetAvailableSeats>
+public class GetAvailableSeatsValidator : AbstractValidator<GetAvailableSeats>
 {
     public GetAvailableSeatsValidator()
     {

diff --git a/.../ReservingSeat/Commands/V1/ReserveSeat.cs → .../Features/ReservingSeat/V1/ReserveSeat.cs b/.../ReservingSeat/Commands/V1/ReserveSeat.cs → .../Features/ReservingSeat/V1/ReserveSeat.cs
@@ -1,4 +1,4 @@
-namespace Flight.Seats.Features.ReservingSeat.Commands.V1;
+namespace Flight.Seats.Features.ReservingSeat.V1;
 
 using System;
 using System.Threading;
@@ -7,10 +7,9 @@ namespace Flight.Seats.Features.ReservingSeat.Commands.V1;
 using BuildingBlocks.Core.CQRS;
 using BuildingBlocks.Core.Event;
 using BuildingBlocks.Web;
-using Data;
 using Duende.IdentityServer.EntityFramework.Entities;
-using Exceptions;
-using Flights.ValueObjects;
+using Flight.Data;
+using Flight.Seats.Exceptions;
 using FluentValidation;
 using Mapster;
 using MapsterMapper;
@@ -19,7 +18,6 @@ namespace Flight.Seats.Features.ReservingSeat.Commands.V1;
 using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Routing;
 using Microsoft.EntityFrameworkCore;
-using ValueObjects;
 
 public record ReserveSeat(Guid FlightId, string SeatNumber) : ICommand<ReserveSeatResult>, IInternalCommand;
 
@@ -63,7 +61,7 @@ private async Task<IResult> ReserveSeat(ReserveSeatRequestDto request, IMediator
     }
 }
 
-internal class ReserveSeatValidator : AbstractValidator<ReserveSeat>
+public class ReserveSeatValidator : AbstractValidator<ReserveSeat>
 {
     public ReserveSeatValidator()
     {

diff --git a/...rvingSeat/Commands/V1/ReserveSeatMongo.cs → ...ures/ReservingSeat/V1/ReserveSeatMongo.cs b/...rvingSeat/Commands/V1/ReserveSeatMongo.cs → ...ures/ReservingSeat/V1/ReserveSeatMongo.cs
@@ -1,4 +1,4 @@
-namespace Flight.Seats.Features.ReservingSeat.Commands.V1;
+namespace Flight.Seats.Features.ReservingSeat.V1;
 
 using System;
 using System.Threading;

diff --git a/src/Services/Flight/src/Flight/Seats/Features/SeatMappings.cs b/src/Services/Flight/src/Flight/Seats/Features/SeatMappings.cs
@@ -6,7 +6,7 @@ namespace Flight.Seats.Features;
 
 using CreatingSeat.V1;
 using MassTransit;
-using ReservingSeat.Commands.V1;
+using ReservingSeat.V1;
 
 public class SeatMappings : IRegister
 {

diff --git a/src/Services/Flight/src/Flight/Seats/Models/Seat.cs b/src/Services/Flight/src/Flight/Seats/Models/Seat.cs
@@ -4,7 +4,7 @@
 namespace Flight.Seats.Models;
 
 using Features.CreatingSeat.V1;
-using Features.ReservingSeat.Commands.V1;
+using Features.ReservingSeat.V1;
 using Flight.Flights.ValueObjects;
 using ValueObjects;
 

diff --git a/...Services/Identity/src/Identity/Identity/Features/RegisteringNewUser/V1/RegisterNewUser.cs b/...Services/Identity/src/Identity/Identity/Features/RegisteringNewUser/V1/RegisterNewUser.cs
@@ -62,7 +62,7 @@ public IEndpointRouteBuilder MapEndpoint(IEndpointRouteBuilder builder)
     }
 }
 
-internal class RegisterNewUserValidator : AbstractValidator<RegisterNewUser>
+public class RegisterNewUserValidator : AbstractValidator<RegisterNewUser>
 {
     public RegisterNewUserValidator()
     {

diff --git a/src/Services/Passenger/src/Passenger/GrpcServer/Services/PassengerGrpcServices.cs b/src/Services/Passenger/src/Passenger/GrpcServer/Services/PassengerGrpcServices.cs
@@ -4,7 +4,7 @@
 namespace Passenger.GrpcServer.Services;
 
 using Mapster;
-using Passengers.Features.GettingPassengerById.Queries.V1;
+using Passengers.Features.GettingPassengerById.V1;
 using GetPassengerByIdResult = Passenger.GetPassengerByIdResult;
 
 public class PassengerGrpcServices : PassengerGrpcService.PassengerGrpcServiceBase

diff --git a/...Passenger/Passengers/Features/CompletingRegisterPassenger/V1/CompleteRegisterPassenger.cs b/...Passenger/Passengers/Features/CompletingRegisterPassenger/V1/CompleteRegisterPassenger.cs
@@ -65,7 +65,7 @@ public IEndpointRouteBuilder MapEndpoint(IEndpointRouteBuilder builder)
     }
 }
 
-internal class CompleteRegisterPassengerValidator : AbstractValidator<CompleteRegisterPassenger>
+public class CompleteRegisterPassengerValidator : AbstractValidator<CompleteRegisterPassenger>
 {
     public CompleteRegisterPassengerValidator()
     {

diff --git a/...sengerById/Queries/V1/GetPassengerById.cs → ...ttingPassengerById/V1/GetPassengerById.cs b/...sengerById/Queries/V1/GetPassengerById.cs → ...ttingPassengerById/V1/GetPassengerById.cs
@@ -1,12 +1,9 @@
-namespace Passenger.Passengers.Features.GettingPassengerById.Queries.V1;
+namespace Passenger.Passengers.Features.GettingPassengerById.V1;
 
 using Ardalis.GuardClauses;
 using BuildingBlocks.Core.CQRS;
 using BuildingBlocks.Web;
-using Data;
-using Dtos;
 using Duende.IdentityServer.EntityFramework.Entities;
-using Exceptions;
 using FluentValidation;
 using Mapster;
 using MapsterMapper;
@@ -16,7 +13,9 @@ namespace Passenger.Passengers.Features.GettingPassengerById.Queries.V1;
 using Microsoft.AspNetCore.Routing;
 using MongoDB.Driver;
 using MongoDB.Driver.Linq;
-using ValueObjects;
+using Passenger.Data;
+using Passenger.Passengers.Dtos;
+using Passenger.Passengers.Exceptions;
 
 public record GetPassengerById(Guid Id) : IQuery<GetPassengerByIdResult>;
 
@@ -51,7 +50,7 @@ public IEndpointRouteBuilder MapEndpoint(IEndpointRouteBuilder builder)
     }
 }
 
-internal class GetPassengerByIdValidator : AbstractValidator<GetPassengerById>
+public class GetPassengerByIdValidator : AbstractValidator<GetPassengerById>
 {
     public GetPassengerByIdValidator()
     {

diff --git a/src/Services/Passenger/tests/IntegrationTest/Passenger/Features/GetPassengerByIdTests.cs b/src/Services/Passenger/tests/IntegrationTest/Passenger/Features/GetPassengerByIdTests.cs
@@ -9,7 +9,7 @@
 
 namespace Integration.Test.Passenger.Features;
 
-using global::Passenger.Passengers.Features.GettingPassengerById.Queries.V1;
+using global::Passenger.Passengers.Features.GettingPassengerById.V1;
 using Humanizer;
 using Thrift.Protocol;
-Original file line number
+Diff line change
@@ Expand Up @@
         }
     }
-    internal class CreateAircraftValidator : AbstractValidator<CreateAircraft>
+    public class CreateAircraftValidator : AbstractValidator<CreateAircraft>
     {
         public CreateAircraftValidator()
         {
@@ Expand Down @@