fix!: Use Headers.prototype.getSetCookie to avoid comma-splitting
#67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Node.js now has `getSetCookie` available, we can use it instead of splitting the header on comma, which was very error-prone. Ref: nodejs/undici#1915 The linked PR was released as Undici v5.19.0, which is first available in Node.js 18.14.1. Since Node.js 18.14.2 has an even more up-tp-date version of Undici (5.20.0), I figured it'd be sensible to raise our requirement to that. BREAKING CHANGE: Engine version requirement raised to Node `>=18.14.2`.
meyfa
force-pushed
the
fix/get-set-cookie
branch
from
ee90121 to
6372509
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Node.js now has
getSetCookieavailable, we can use it instead of splitting the header on comma, which was very error-prone.Ref: nodejs/undici#1915
The linked PR was released as Undici v5.19.0, which is first available in Node.js 18.14.1. Since Node.js 18.14.2 has an even more up-tp-date version of Undici (5.20.0), I figured it'd be sensible to raise our requirement to that.
BREAKING CHANGE: Engine version requirement raised to Node
>=18.14.2.