Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nasum #7

Merged
merged 3 commits into from
Dec 13, 2022
Merged

Fix nasum #7

merged 3 commits into from
Dec 13, 2022

Conversation

michaelmcd18
Copy link
Collaborator

Replace metrumRG version of nasum with Tim Waterhouse version

Remove default ID in nsub function

@michaelmcd18 michaelmcd18 linked an issue Nov 2, 2022 that may be closed by this pull request
Replace nasum() with new version #6
Closed
@graceannobrien
Copy link
Collaborator

@michaelmcd18 For nsub, it might be nice to have warning/error message that id column needs to be specified. Right now, it just returns 1 when there is no ID col specific

@michaelmcd18 michaelmcd18 removed the request for review from andersone1 December 13, 2022 13:35
@michaelmcd18 michaelmcd18 merged commit 02cf7fe into main Dec 13, 2022
@michaelmcd18 michaelmcd18 deleted the fix-nasum branch September 11, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graceannobrien graceannobrien graceannobrien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace nasum() with new version
2 participants
@michaelmcd18 @graceannobrien