Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update numeric_time #43

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Update numeric_time #43

merged 3 commits into from
Apr 22, 2024

Conversation

michaelmcd18
Copy link
Collaborator

No description provided.

@michaelmcd18 michaelmcd18 linked an issue Apr 15, 2024 that may be closed by this pull request
numeric_time doesn't handle negative numbers #40
Closed
@michaelmcd18
Copy link
Collaborator Author

@callistosp Thanks for finding this bug, I believe the function now treats negative times correctly

>   times2 <- c("3:05", "-3:05", "-11:40")
>   numeric_time(times2)
[1]   3.08  -3.08 -11.67

@michaelmcd18 michaelmcd18 merged commit ade5318 into main Apr 22, 2024
2 checks passed
@michaelmcd18 michaelmcd18 deleted the update-numeric-time branch April 22, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andersone1 andersone1 andersone1 approved these changes

@graceannobrien graceannobrien Awaiting requested review from graceannobrien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

numeric_time doesn't handle negative numbers
2 participants
@michaelmcd18 @andersone1