Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DESCRIPTION: drop packages from Imports that aren't used in R/ #44

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

kyleam
Copy link
Collaborator

@kyleam kyleam commented Sep 14, 2023

The 'R CMD check' for mpn.scorecard has the following note [*]:

Namespaces in Imports field not imported from:
   ‘here’ ‘markdown’ ‘tidyr’
  All declared Imports should be used.

here is only used in the top-level update-readme.R, not in any R/ code, so move it to pkgr.yml.

tidyr is only used in test code, so move it to Suggests.

markdown isn't used at all, so just remove it.

[*] This isn't flagged by the default devtools::check() (which
passes --as-cran) until R 4.2 (see revision 81155).

The 'R CMD check' for mpn.scorecard has the following note [*]:

    Namespaces in Imports field not imported from:
       ‘here’ ‘markdown’ ‘tidyr’
      All declared Imports should be used.

here is only used in the top-level update-readme.R, not in any R/
code, so move it to pkgr.yml.

tidyr is only used in test code, so move it to Suggests.

markdown isn't used at all, so just remove it.

[*] This isn't flagged by the default `devtools::check()` (which
    passes --as-cran) until R 4.2 (see revision 81155).
@kyleam kyleam requested a review from barrettk September 14, 2023 14:51
@kyleam kyleam added this to the 0.2.0 release milestone Sep 14, 2023
Copy link
Collaborator

@barrettk barrettk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

I will say markdown is a weird one though. Sometimes (even when I have rmarkdown installed), I will get a pop-up when trying to create a new RMD file saying

"Warning: a later version of markdown is required"

.. or something to that effect.

It may make sense to move markdown to just the pkgr file at some point, but R CMD Check / devtools::test() passes on my end so im good with how it is.

@kyleam
Copy link
Collaborator Author

kyleam commented Sep 14, 2023

I will say markdown is a weird one though. [...]

Okay, thanks for filling in those details. I like your plan of waiting to see if it crops up and then adding to pkgr.yml.

@kyleam kyleam merged commit 5f10f5e into main Sep 14, 2023
@kyleam kyleam deleted the demote-non-pkg-imports branch September 14, 2023 19:25
@barrettk barrettk mentioned this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants