Trac matrix fixes #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- needs test - changed filter_symbol_functions to filter based on symbol patterns instead of specific functions
- support for setGeneric and other types should not be needed. - TODO: add test scenario - still may refactor this function to make use of `parse`, and attempt to move away from regex, but this is a good baseline for capturing these types of functions
- mutli-lined function declarations - no R directory - After writing the test for the traceability matrix, I realized we needed one for testing the expected results of this scenario as well. Could have been done in a separate PR, but it seemed relevant enough since I had to add this new scenario to the setup file anyways - We should confirm if we want covr to fail if there is no R/ directory. That refactor should be a separate PR if done. There are several cases where R packages do not have R/ directories, and im not sure it makes sense to penalize the score for those cases.
- traceability matrix cannot be created without exports: error out
This was referenced Aug 24, 2023
Closed
|
This was superseded by gh-42, with many of these changes incorporated there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes amendments to the traceability matrix related to #19. It also captures other discovered issues.
exportPatternmethods, or mutli-lined function declarations being used.initerror: some cases were addressed in trace-matrix-reorg, but some were related to noR/directory existing. Support for noR/directory was added.parseover regex for mapping the test files was made. However, some improvements were made to the traceability matrix based on the results of these two packagescloses #19