fix: use global() to get performance API on wasm32-unknown-unknown

[Officeyutong]

Currently quanta uses window.performance to access Performance API in browser, which will not work in WebWorkers. In WebWorkers, there is no window object, but performance is in the global space.

This PR uses web_sys::js_sys::global() to access the global scope, and look up for performance in that, which will both work on webpage and WebWorkers.

See https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Functions_and_classes_available_to_workers for more details

[tobz]

Thanks for opening this PR!

Taking a look at the code, it seems like this is going to be somewhat inefficient, reflecting through the global scope on every single call.

Is my intuition wrong here? Could we not instead simply query for the Performance class when constructing Monotonic so that there's always a live reference to it to directly use?

[Officeyutong]

Thanks for opening this PR!

Taking a look at the code, it seems like this is going to be somewhat inefficient, reflecting through the global scope on every single call.

Is my intuition wrong here? Could we not instead simply query for the Performance class when constructing Monotonic so that there's always a live reference to it to directly use?

You are right, Reflection is relatively slow since its equal to object[attribute] in JS. I'll try to store a reference to Performance class to avoid frequent call to Reflection

[Officeyutong]

Thanks for opening this PR!

Taking a look at the code, it seems like this is going to be somewhat inefficient, reflecting through the global scope on every single call.

Is my intuition wrong here? Could we not instead simply query for the Performance class when constructing Monotonic so that there's always a live reference to it to directly use?

Updated now. I also splitted wasm.rs to wasm_browser.rs and wasm_wasi.rs, since implementation of these two platforms are completely different

[Officeyutong]

Hi @tobz , how's this issue going on?

[tobz]

Apologies: life and work have been pretty busy lately. :)

I left a common about how we caching the Performance object, and in particular about how we're overriding the fact that it's !Send/!Sync.

[tobz]

Overall, these changes seem reasonable to me. 👍🏻

[Officeyutong]

Overall, these changes seem reasonable to me. 👍🏻

Hi, when can we get this PR merged

[tobz]

👋🏻

Going to merge these now, but I'll have to fix the MSRV and CI afterwards and make sure things are still green before I can cut a release.

[tobz]

Released as [email protected].

Thanks again for your contribution!