Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pycodestyle: fixes #2172

Merged
merged 2 commits into from
Apr 12, 2018
Merged

pycodestyle: fixes #2172

merged 2 commits into from
Apr 12, 2018

Conversation

matthewrmshin
Copy link
Member

@matthewrmshin matthewrmshin commented Apr 11, 2018 •
edited
Loading

W503 and W504, ignore with reason:

  • Both are acceptable by PEP8. We'll switch on W504 if we are able to migrate to the slightly better style.

W605 invalid escape sequence:

  • In this PR, I have modified the code to raw quote regular expression strings with escape sequence.

@matthewrmshin matthewrmshin added this to the next-release milestone Apr 11, 2018
@matthewrmshin matthewrmshin self-assigned this Apr 11, 2018
@matthewrmshin matthewrmshin changed the title pycodestyle: ignore w503 and w504 pycodestyle: fixes Apr 11, 2018
@matthewrmshin matthewrmshin force-pushed the fix-pycodestyle-w503-w504 branch from 53e34ad to d73939c Compare April 11, 2018 15:26
sadielbartholomew
sadielbartholomew approved these changes Apr 12, 2018
View reviewed changes
Copy link
Contributor

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. Line-breaking before binary operator preference noted for future dev work.

@sadielbartholomew sadielbartholomew merged commit 34d9d58 into metomi:master Apr 12, 2018
@matthewrmshin matthewrmshin deleted the fix-pycodestyle-w503-w504 branch April 12, 2018 11:40
@sadielbartholomew sadielbartholomew mentioned this pull request Apr 12, 2018
Merged
@oliver-sanders oliver-sanders mentioned this pull request Apr 13, 2018
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders oliver-sanders approved these changes

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees

@matthewrmshin matthewrmshin

Labels
None yet
Projects
None yet
Milestone
2018.05.0
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewrmshin @oliver-sanders @sadielbartholomew