Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abort widget check if gtk 2.0 not available. #2169

Merged
merged 1 commit into from
Apr 9, 2018
Merged

Abort widget check if gtk 2.0 not available. #2169

merged 1 commit into from
Apr 9, 2018

Conversation

oliver-sanders
Copy link
Member

In certain situations the DISPLAY variable can be provided where it is not appropriate.

@oliver-sanders oliver-sanders added this to the next-release milestone Mar 27, 2018
@oliver-sanders oliver-sanders self-assigned this Mar 27, 2018
matthewrmshin
matthewrmshin approved these changes Apr 9, 2018
View reviewed changes
Copy link
Member

@matthewrmshin matthewrmshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough.

sadielbartholomew
sadielbartholomew approved these changes Apr 9, 2018
View reviewed changes
Copy link
Contributor

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not possible to recreate the error for testing as discussed, but this is a logically sound solution.

@sadielbartholomew sadielbartholomew merged commit 8faf7a9 into metomi:master Apr 9, 2018
@oliver-sanders oliver-sanders deleted the display-to-gtk-import branch May 18, 2018 09:20
@oliver-sanders oliver-sanders mentioned this pull request May 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewrmshin matthewrmshin matthewrmshin approved these changes

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
None yet
Projects
None yet
Milestone
2018.05.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oliver-sanders @matthewrmshin @sadielbartholomew