Skip to content

Commit

Permalink
Merge pull request #66 from meteor/abernix/update-segment-id-js
Browse files Browse the repository at this point in the history
Update Segment.io Analytics code to latest version, v4.1.0.
  • Loading branch information
abernix authored Apr 13, 2018
2 parents dff019a + 8b092db commit 765b7aa
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
## vNEXT

* Elements with HTML IDs of `analytics` will no longer break Segment.io.
[PR #](https://github.com/meteor/meteor-theme-hexo/pull/)
[PR #65](https://github.com/meteor/meteor-theme-hexo/pull/65)
* Update Segment.io JavaScript code to latest version.
[PR #66](https://github.com/meteor/meteor-theme-hexo/pull/66)

## v1.0.5

Expand Down
7 changes: 4 additions & 3 deletions layout/layout.ejs
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@
<% } %>
<% if (config.apis && config.apis.segment) { %>
<<<<<<< HEAD
<%#
We define `analytics` in the global context to guard against HTML elements on the page
potentially named "analytics". This is necessary because we have some docs pages with
Expand All @@ -125,10 +126,10 @@
%>
var analytics;
<%# Segment.io's analytics code. %>
!function(){var analytics=window.analytics=window.analytics||[];if(!analytics.initialize)if(analytics.invoked)window.console&&console.error&&console.error("Segment snippet included twice.");else{analytics.invoked=!0;analytics.methods=["trackSubmit","trackClick","trackLink","trackForm","pageview","identify","reset","group","track","ready","alias","page","once","off","on"];analytics.factory=function(t){return function(){var e=Array.prototype.slice.call(arguments);e.unshift(t);analytics.push(e);return analytics}};for(var t=0;t<analytics.methods.length;t++){var e=analytics.methods[t];analytics[e]=analytics.factory(e)}analytics.load=function(t){var e=document.createElement("script");e.type="text/javascript";e.async=!0;e.src=("https:"===document.location.protocol?"https://":"http://")+"cdn.segment.com/analytics.js/v1/"+t+"/analytics.min.js";var n=document.getElementsByTagName("script")[0];n.parentNode.insertBefore(e,n)};analytics.SNIPPET_VERSION="3.1.0";
<!-- Segment.io -->
!function(){var analytics=window.analytics=window.analytics||[];if(!analytics.initialize)if(analytics.invoked)window.console&&console.error&&console.error("Segment snippet included twice.");else{analytics.invoked=!0;analytics.methods=["trackSubmit","trackClick","trackLink","trackForm","pageview","identify","reset","group","track","ready","alias","debug","page","once","off","on"];analytics.factory=function(t){return function(){var e=Array.prototype.slice.call(arguments);e.unshift(t);analytics.push(e);return analytics}};for(var t=0;t<analytics.methods.length;t++){var e=analytics.methods[t];analytics[e]=analytics.factory(e)}analytics.load=function(t,e){var n=document.createElement("script");n.type="text/javascript";n.async=!0;n.src=("https:"===document.location.protocol?"https://":"http://")+"cdn.segment.com/analytics.js/v1/"+t+"/analytics.min.js";var o=document.getElementsByTagName("script")[0];o.parentNode.insertBefore(n,o);analytics._loadOptions=e};analytics.SNIPPET_VERSION="4.1.0";
analytics.load("<%- config.apis.segment %>");
analytics.page()
analytics.page();
}}();
<% } %>
Expand Down

0 comments on commit 765b7aa

Please sign in to comment.