Separating Atmosphere and npm package sections #410

jamielob · 2016-04-29T23:59:35Z

Hey @tmeasday, here's the PR we discussed.

Changed Build Section organization to separate Atmosphere and npm.

stubailo · 2016-04-30T00:04:13Z

content/using-atmosphere-packages.md

+discourseTopicId: 20192
+---
+
+Atmosphere packages are packages written specifically for Meteor and have several advantages over npm when used with Meteor. In particular, Atmosphere packages can:


I'd move this to the atmosphere vs npm section, since if you are comparing the two you would want this information.

(Same for the analogous section in the NPM article?)

I want to keep things in line with the rest of the guide - is it bad practice to have a <h2> as the first thing in a section? i.e. Should there always be some introductory text?

stubailo · 2016-04-30T00:08:51Z

Also, something to think about is whether we should redirect the old page URLs somehow, but I'm not sure exactly how that would work.

Couldn't find a way to redirect specific # entry points, but I have redirected the old using-packages and writing-packages pages to the new atmosphere-vs-npm page.

jamielob · 2016-05-02T16:25:47Z

Hey @stubailo - I've added redirects using hexo-generator-alias. I couldn't find an easy way with hexo to redirect specific # entry points so I've redirected both the old pages to the new atmosphere-vs-npm page so that any old links don't get re-directed to an incorrect atmosphere or npm specific topic.

tmeasday · 2016-05-02T16:59:16Z

@jamielob this looks great! Thanks so much!

I think we need a better system for the redirects however. I've already had to do something similar for the docs so let me think a bit about how to make it generic and use it here.

stubailo · 2016-05-02T17:42:49Z

@tmeasday does S3 support a 404 route? Then we could just do a JS redirect from there or something?

tmeasday · 2016-05-02T17:45:05Z

Yes, it sure does. We'll make 404s -> index and then the index figure it out.

But the tricky part is outlining the hashes .. like

using-packages.html#client-npm -> using-npm-packages.html#client-npm

This reverts commit 9d7f043.

This reverts commit 6e1fb8c.

jamielob · 2016-05-02T19:03:23Z

I've just gone through the old using-packages section and mapped each of the id entry points to their new locations. If this is helpful for you, let me know and I'll do the same for the writing-packages page.

using-packages.md#npm > using-npm-packages.md
using-packages.md#client-npm > using-npm-packages.md#client-npm
using-packages.md#installing-npm > using-npm-packages.md#installing-npm
using-packages.md#using-npm > using-npm-packages.md#using-npm
using-packages.md#npm-styles > using-npm-packages.md#npm-styles
using-packages.md#npm-shrinkwrap > using-npm-packages.md#npm-shrinkwrap 
using-packages.md#atmosphere >  using-atmosphere-packages.md
using-packages.md#atmosphere-searching > using-atmosphere-packages.md#atmosphere-searching
using-packages.md#atmosphere-naming > using-atmosphere-packages.md#atmosphere-naming
using-packages.md#installing-atmosphere > using-atmosphere-packages.md#installing-atmosphere
using-packages.md#using-atmosphere > using-atmosphere-packages.md#using-atmosphere
using-packages.md#importing-atmosphere-styles > using-atmosphere-packages.md#importing-atmosphere-styles
using-packages.md#peer-npm-dependencies > using-atmosphere-packages.md#peer-npm-dependencies
using-packages.md#package-namespacing > using-atmosphere-packages.md#package-namespacing
using-packages.md#async-callbacks > using-npm-packages.md#async-callbacks
using-packages.md#bind-environment > using-npm-packages.md#bind-environment
using-packages.md#wrap-async > using-npm-packages.md#wrap-async
using-packages.md#promises > using-npm-packages.md#promises
using-packages.md#overriding-packages >  writing-npm-packages.md#overriding-npm-packages
using-packages.md#npm-overriding > writing-npm-packages.md#overriding-npm-packages
using-packages.md#atmosphere-overriding > writing-atmosphere-packages.md#overriding-atmosphere-packages
using-packages.md#npm-shrinkpack > using-npm-packages.md#npm-shrinkpack

tmeasday · 2016-05-02T19:06:38Z

@jamielob - thanks. Sure, if it's easy--otherwise I can do it pretty easily too.

Couldn't find a way to redirect specific # entry points, but I have redirected the old using-packages and writing-packages pages to the new atmosphere-vs-npm page.

This reverts commit 9d7f043.

Jamielob master

jamielob · 2016-05-05T23:43:17Z

Well that was a 🐶

@tmeasday Mind if I leave the redirects for you? I removed the hexo alias package and basic forwarding that I had originally done.

tmeasday · 2016-05-05T23:47:40Z

No problem @jamielob. Let's get this merged ASAP :)

Thanks for your hard work on this.

jamielob · 2016-05-06T00:00:17Z

Cheers! 👍

PascalPixel · 2016-05-16T10:17:32Z

On http://guide.meteor.com/1.3-migration.html it links to https://github.com/meteor/guide/blob/master/content/using-packages.html which is empty
should link to http://guide.meteor.com/using-npm-packages.html

tmeasday · 2016-05-17T18:45:11Z

Thanks @PascalPencil -- the redirects should work[1] - I must have broken them.

[1] It does actually link to guide.meteor.com

PascalPixel · 2016-05-18T08:12:45Z

@tmeasday keep up the good work 💯

Jamie Loberman added 10 commits April 29, 2016 16:23

Add Atmosphere vs npm

511e7ad

Atmosphere section

18f9e30

npm section

f239fc8

Move build plugins into build system section

3896e53

Remove old section

c1900ad

New sidebar layout

676dca4

Fixing links

c730dca

Move overriding to writing section

aa56245

Fixed old changelog PR reference

dfca3ec

Added Changeling description of PR

7efc7e9

stubailo reviewed Apr 30, 2016
View reviewed changes

Remove overriding packages note

904d882

Jamie Loberman added 4 commits April 29, 2016 19:11

Moved intro paragraphs into atmosphere vs npm

f18d60f

Added npm hexo-generator-alias for redirects

137afcc

Couldn't find a way to redirect specific # entry points, but I have redirected the old using-packages and writing-packages pages to the new atmosphere-vs-npm page.

Temporary discourse topics - recommend adding new

2277e0a

Added note about naming npm packages.

601a4fb

Jamie Loberman added 5 commits May 2, 2016 11:02

Added back missing nam styles section

6e1fb8c

Added back missing atmosphere styles section

9d7f043

Revert "Added back missing atmosphere styles section"

d52232a

This reverts commit 9d7f043.

Revert "Added back missing nam styles section"

68c7375

This reverts commit 6e1fb8c.

Adding back missing content

28c5bcb

Updating atmosphere list and links

e5b9375

Jamie Loberman and others added 22 commits May 5, 2016 16:08

Fixing conflict

e76400c

Move build plugins into build system section

5cdee26

Fixing second conflict

e3b766f

New sidebar layout

7ef34ba

Fixing links

abf9529

Move overriding to writing section

2530f9e

Fixing conflict 3

c90eb31

Remove overriding packages note

86051a3

Moved intro paragraphs into atmosphere vs npm

486f447

Added npm hexo-generator-alias for redirects

0ff5963

Couldn't find a way to redirect specific # entry points, but I have redirected the old using-packages and writing-packages pages to the new atmosphere-vs-npm page.

Temporary discourse topics - recommend adding new

9c2a733

Added note about naming npm packages.

14449c1

Fixing conflict 5

d4f3a11

Added back missing atmosphere styles section

6f3b00b

Revert "Added back missing atmosphere styles section"

83f0e0a

This reverts commit 9d7f043.

Fixing conflict 6

6f7182c

Fixing conflict 7

91447b1

Updating atmosphere list and links

3481234

Fixing conflict 8

aac48c9

Removing the hexo alias package

e76db2b

Tidy up

ef0140b

Merge pull request #1 from jamielob/jamielob-master

398f773

Jamielob master

tmeasday merged commit 87c96b5 into meteor:master May 5, 2016

tmeasday added a commit that referenced this pull request May 6, 2016

Setup redirects for old package content #410

7dcec28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Separating Atmosphere and npm package sections #410

Separating Atmosphere and npm package sections #410

jamielob commented Apr 29, 2016

stubailo Apr 30, 2016

stubailo Apr 30, 2016

jamielob Apr 30, 2016 •

edited

Loading

stubailo commented Apr 30, 2016

jamielob commented May 2, 2016 •

edited

Loading

tmeasday commented May 2, 2016

stubailo commented May 2, 2016

tmeasday commented May 2, 2016 •

edited

Loading

jamielob commented May 2, 2016

tmeasday commented May 2, 2016

jamielob commented May 5, 2016

tmeasday commented May 5, 2016

jamielob commented May 6, 2016

PascalPixel commented May 16, 2016

tmeasday commented May 17, 2016

PascalPixel commented May 18, 2016

Separating Atmosphere and npm package sections #410

Separating Atmosphere and npm package sections #410

Conversation

jamielob commented Apr 29, 2016

stubailo Apr 30, 2016

Choose a reason for hiding this comment

stubailo Apr 30, 2016

Choose a reason for hiding this comment

jamielob Apr 30, 2016 • edited Loading

Choose a reason for hiding this comment

stubailo commented Apr 30, 2016

jamielob commented May 2, 2016 • edited Loading

tmeasday commented May 2, 2016

stubailo commented May 2, 2016

tmeasday commented May 2, 2016 • edited Loading

jamielob commented May 2, 2016

tmeasday commented May 2, 2016

jamielob commented May 5, 2016

tmeasday commented May 5, 2016

jamielob commented May 6, 2016

PascalPixel commented May 16, 2016

tmeasday commented May 17, 2016

PascalPixel commented May 18, 2016

jamielob Apr 30, 2016 •

edited

Loading

jamielob commented May 2, 2016 •

edited

Loading

tmeasday commented May 2, 2016 •

edited

Loading