Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding candy_guard parser #6

Merged
merged 2 commits into from
Sep 22, 2022
Merged

Adding candy_guard parser #6

merged 2 commits into from
Sep 22, 2022

Conversation

danenbm
Copy link
Contributor

@danenbm danenbm commented Sep 20, 2022

Notes

@danenbm danenbm changed the title Danenbm/candy guard parser Candy guard parser Sep 20, 2022
@danenbm danenbm changed the title Candy guard parser Adding candy_guard parser Sep 20, 2022
@danenbm danenbm changed the base branch from main to danenbm/candy_machine_core_parser September 20, 2022 23:09
@febo
Copy link

febo commented Sep 21, 2022

All good with the implementation, below are some aspects that we might need to think about:

  1. There is a MintCounter PDA per wallet, which in turn can exist in multiple groups (GuardSets); therefore, we will probably have thousands of PDAs per Candy Guard account. It would be interesting to index those since any UI will need to fetch the PDA to check whether a wallet can mint or not, otherwise the guard validation could fail and the wallet charged a bot tax.
  2. It is very likely that future guards incorporate other PDAs, so it is possible that PDAs will exist before the parser code gets updated. Perhaps we need a good way to handle unrecognized accounts in the parser – some sort of categorization that a new PDA is being used.

@danenbm danenbm force-pushed the danenbm/candy_machine_core_parser branch from 7fdcbc9 to 7245dd8 Compare September 21, 2022 22:07
Base automatically changed from danenbm/candy_machine_core_parser to main September 21, 2022 22:08
@danenbm danenbm force-pushed the danenbm/candy_guard_parser branch from ab43aa0 to 3246b2b Compare September 21, 2022 22:15
@austbot
Copy link
Contributor

austbot commented Sep 22, 2022

@febo the parser gets all current accounts flushed at it during startup, but you are right unless we know the structure of thoise pdas we will have to just store rraw bytes. I think we have to be diligent to get parser code out before major updates to core programs, in this case we can store all accounts from candy guard and reup later

@danenbm danenbm force-pushed the danenbm/candy_guard_parser branch from 3246b2b to f09efab Compare September 22, 2022 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants