Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add container image build wf template #833

Merged
merged 1 commit into from
Aug 8, 2024
Merged

🌱 Add container image build wf template #833

merged 1 commit into from
Aug 8, 2024

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Aug 7, 2024 •
edited
Loading

This template is not meant to be used in this repo, but to be referenced by container build wf from other repos.

An example of how it could be used: https://github.com/metal3-io/baremetal-operator/actions/runs/10280659565/job/28448467379?pr=1861

@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2024
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 7, 2024
@mquhuy mquhuy force-pushed the mquhuy/add-container-image-build-wf-template branch 4 times, most recently from e4732e6 to e72bc66 Compare August 7, 2024 08:12
@mquhuy mquhuy changed the title [WIP] 🌱 Add container image build wf template 🌱 Add container image build wf template Aug 7, 2024
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Aug 7, 2024

/cc @tuminoid @kashifest @Rozzii @Sunnatillo @adilGhaffarDev @NymanRobin

@mquhuy mquhuy mentioned this pull request Aug 7, 2024
Merged
@mquhuy mquhuy force-pushed the mquhuy/add-container-image-build-wf-template branch from e72bc66 to ec066be Compare August 7, 2024 08:31
@tuminoid
Copy link
Member

tuminoid commented Aug 7, 2024

Can you already test this, PR + PR combo?

@mquhuy
Copy link
Member Author

mquhuy commented Aug 7, 2024

Can you already test this, PR + PR combo?

Yes. I have tested it, but I modified the BMO PR now to illustrate how the test is: metal3-io/baremetal-operator#1861

tuminoid
tuminoid reviewed Aug 7, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

I think we can merge this already, as its not doing anything on its own. It is to be called by other repos, starting with BMO and then all the other repos converted to this.

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2024
@tuminoid
Copy link
Member

tuminoid commented Aug 7, 2024

/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 7, 2024
@mquhuy mquhuy force-pushed the mquhuy/add-container-image-build-wf-template branch 2 times, most recently from cb3449d to b65e3d6 Compare August 7, 2024 11:36
@mquhuy mquhuy force-pushed the mquhuy/add-container-image-build-wf-template branch 10 times, most recently from 51c2e4f to 734e34d Compare August 7, 2024 12:37
@mquhuy mquhuy force-pushed the mquhuy/add-container-image-build-wf-template branch from 734e34d to 865d10b Compare August 7, 2024 13:21
@mquhuy mquhuy requested a review from tuminoid August 7, 2024 13:25
@tuminoid
Copy link
Member

tuminoid commented Aug 7, 2024

So we changed from username + token to username + password? Is this tested now?

@tuminoid
Copy link
Member

tuminoid commented Aug 8, 2024

/override metal3-ubuntu-e2e-integration-test-main

/cc @kashifest
Please lgtm this.

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

/cc @kashifest
Please lgtm this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kashifest
kashifest reviewed Aug 8, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2024
@metal3-io-bot metal3-io-bot merged commit 3b89010 into metal3-io:main Aug 8, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest kashifest left review comments

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

@Sunnatillo Sunnatillo Awaiting requested review from Sunnatillo

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

@NymanRobin NymanRobin Awaiting requested review from NymanRobin

@Rozzii Rozzii Awaiting requested review from Rozzii

@tuminoid tuminoid Awaiting requested review from tuminoid

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mquhuy @tuminoid @metal3-io-bot @kashifest