WIP: Implement upload/download of trace records #22
+552
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxor
force-pushed
the
feat-upload-download-traces
branch
2 times, most recently
from
09e65ca to
c2f7a8a
Compare
Currently there is a GUI for the upload button When clicked, it zips the given trace with a random password encryption and uploads it to the provided web api root
…ime to the database file
In the nim-lan/zip library password encryption is not supported so we are currently using the standard zip and unzip packages
Still need to encrypt the file and set up the codetracer web api
…ugh <downloadId>::<password>
… and auto open on download complete
…ding on the trace fields Add fields for the downloadKey, controlId and expireTime to the trace object Add a Command for delete of trace files Handle deleting of the trace file's download key, controlId and expireTime
…nished and handle the frontend update of the trace object
pxor
force-pushed
the
feat-upload-download-traces
branch
from
f838285 to
b8a295a
Compare
Madman10K
requested changes
Mar 11, 2025
There was a problem hiding this comment.
Looks good to me, just needs to be changed to follow the common code style. Maybe @alehander92 can add to the review
alehander92
reviewed
Mar 11, 2025
| @@ -54,7 +54,7 @@ proc recordSymbols(sourceDir: string, outputFolder: string, lang: Lang) = | |||
| # it's still good to have an option/opt-out, so we leave that | |||
| # as a flag in the internals, but not exposed to user yet | |||
| # that's why for now it's hardcoded for db | |||
| const DB_SELF_CONTAINED_DEFAULT = true | |||
| const DB_SELF_CONTAINED_DEFAULT* = true | |||
There was a problem hiding this comment.
maybe we need to move this to globals.nim
There was a problem hiding this comment.
I just noticed that it is exported. I support moving this too
| @@ -53,16 +53,16 @@ proc downloadCommand*(traceRegistryId: string) = | |||
| else: | |||
| let downloadId = stringSplit[1] | |||
| let password = stringSplit[2] | |||
| let zipPath = "/tmp/tmp.zip" | |||
| let zipPath = codetracerTmpPath / "tmp.zip" | |||
There was a problem hiding this comment.
this is /tmp/codetracer/ on unix though, maybe that's ok, just noting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.