run prettier on sdk readme #48905
Merged
run prettier on sdk readme #48905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@npretto You have modified embedding SDK code. Please make sure the PR title follows Conventional Commits style.
These types Please also make sure to include For example, these are valid PR titles:
|
npretto
added
the
backport
npretto
commented
Oct 21, 2024
| @@ -124,11 +124,11 @@ const metabaseConfig = { | |||
| ### JWT Authentication | |||
There was a problem hiding this comment.
Press the magic button ^
It will show a hugely better diff
github-automation-metabase
pushed a commit
that referenced
this pull request
Oct 21, 2024
* run prettier on sdk readme * fix code snippets so that prettier can format them * put back the empty new line on the package.json
github-automation-metabase
added a commit
that referenced
this pull request
Oct 21, 2024
* run prettier on sdk readme * fix code snippets so that prettier can format them * put back the empty new line on the package.json Co-authored-by: Nicolò Pretto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I opened it, changed a file, saved it and it all changed, which makes me sadThe formatting on the code samples were not consistent with formatting, there shouldn't be any downside in having the readme formatted by prettier.
I also added it to the lint-staged rules, so that we don't have to rely on people having prettier on the IDE
Non formatting changes
Due to some snippets being technically not valid code, there are some code changes.
Mostly
{...}being modified intoI also modified some
into
To make them consistent