fix: update URL import, URL -> ImageContentItemImageURL #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattf
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn,
raghotham,
dineshyv,
vladimirivic,
sixianyi0721,
ehhuang and
terrytangyuan
as code owners
facebook-github-bot
added
the
CLA Signed
|
cc @yanxi0830 |
ashwinb
approved these changes
Feb 21, 2025
| @@ -59,7 +59,7 @@ | |||
| DUMMY_TEXT2 = TextContentItem(text=DUMMY_STRING2, type="text") | |||
| # TODO(mf): add a real image URL and base64 string | |||
| DUMMY_IMAGE_URL = ImageContentItem( | |||
| image=ImageContentItemImage(url=URL(uri="https://example.com/image.jpg")), type="image" | |||
| image=ImageContentItemImage(url=ImageContentItemImageURL(uri="https://example.com/image.jpg")), type="image" | |||
There was a problem hiding this comment.
it is significantly less common to use very strong types in client code. most SDK samples you see (OpenAI's or others) often just use loosely typed dicts (dict(url=dict(uri=...)) or {"url": {"uri": ...} }
ashwinb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fixes test to use new name for URL import
Test Plan
LLAMA_STACK_BASE_URL=http://localhost:8321 pytest -v tests/client-sdk/inference/test_embedding.py --embedding-model baai/bge-m3