fix(api): update embeddings signature so inputs and outputs list align #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwinb
requested review from
yanxi0830,
hardikjshah,
dltn,
raghotham,
dineshyv,
vladimirivic,
sixianyi0721,
ehhuang and
terrytangyuan
as code owners
facebook-github-bot
added
the
CLA Signed
ashwinb
changed the title
ashwinb
force-pushed
the
emb_content_items
branch
from
9b37ad9 to
6e8d7e6
Compare
|
Looks reasonable, can you add a test please |
ashwinb
force-pushed
the
emb_content_items
branch
from
6e8d7e6 to
675ca3e
Compare
ashwinb
force-pushed
the
emb_content_items
branch
from
675ca3e to
378e160
Compare
hardikjshah
approved these changes
Feb 21, 2025
mattf
added a commit
to mattf/llama-stack
that referenced
this pull request
Feb 21, 2025
ashwinb
pushed a commit
that referenced
this pull request
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Issue #922
The change is slightly backwards incompatible but no callsite (in our client codebases or stack-apps) every passes a depth-2
List[List[InterleavedContentItem]](which is now disallowed.)Test Plan
$ cd llama_stack/providers/tests/inference $ pytest -s -v -k fireworks test_embeddings.py \ --inference-model nomic-ai/nomic-embed-text-v1.5 --env EMBEDDING_DIMENSION=784 $ pytest -s -v -k together test_embeddings.py \ --inference-model togethercomputer/m2-bert-80M-8k-retrieval --env EMBEDDING_DIMENSION=784 $ pytest -s -v -k ollama test_embeddings.py \ --inference-model all-minilm:latest --env EMBEDDING_DIMENSION=784Also ran
tests/client-sdk/inference/test_embeddings.py