Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version number in Python example #643

Merged
merged 1 commit into from
Aug 25, 2024
Merged

Conversation

wstnmssr
Copy link
Contributor

What does this PR do?

Replace llama3 with llama3.1 in code example to avoid model not found error.

Feature/Issue validation/testing

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

To reproduce the error, copy and paste the sample python code. The response is {'error': 'model "llama3" not found, try pulling it first'}.

This fix was tested manually by observing a proper, non-error response when using the appropriate version number.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Thanks for contributing 🎉!

Replace `llama3` with `llama3.1` to avoid model not found error
@facebook-github-bot
Copy link

Hi @wstnmssr!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@init27
Copy link
Contributor

init27 commented Aug 23, 2024

Thanks @wstnmssr can you please sign the CLA?

@wstnmssr
Copy link
Contributor Author

Thanks @wstnmssr can you please sign the CLA?

Hey @init27, I tried to do this but after submitting the form, I was not able to authenticate with my GitHub account. Upon submitting, I was taken to https://code.facebook.com/cla/individual/sign/, which was just a blank page.

@init27
Copy link
Contributor

init27 commented Aug 25, 2024

@wstnmssr Can you try with https://code.facebook.com/cla/individual link?

You should be checking at https://code.facebook.com/cla

Let me know if you run into any issues

@wstnmssr
Copy link
Contributor Author

@init27 That's the link I've been using, and I'm running into the same issue I described earlier. When I am redirected to the URL I mentioned, this is all I see:
image

@init27
Copy link
Contributor

init27 commented Aug 25, 2024

That's strange-can you try the same with a different browser please?

@wstnmssr
Copy link
Contributor Author

That's strange-can you try the same with a different browser please?

Looks like it works in safari. I agree, odd that it is not working for me in chrome.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@init27 init27 self-assigned this Aug 25, 2024
@init27 init27 merged commit 04766dc into meta-llama:main Aug 25, 2024
3 checks passed
@wstnmssr wstnmssr deleted the patch-1 branch August 25, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants