Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected wrong order of commands #602

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

BakungaBronson
Copy link
Contributor

In the notebook, under section 4.3.2, LangChain Q&A Retriever, the code block where we test chat history has two commands switched in order, resulting in an error while running. Switching to have the "query" variable set first fixes this issue.

What does this PR do?

This PR switches two lines of code, with one meant to run before the other. The

Feature/Issue validation/testing

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Thanks for contributing 🎉!

In the notebook, under section 4.3.2, LangChain Q&A Retriever, the code block where we test chat history has two commands switched in order, resulting in an error while running. Switching to have the "query" variable set first fixes this issue.
Copy link
Contributor

@mreso mreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! LGTM

@mreso mreso merged commit 9b3dabc into meta-llama:main Aug 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants