New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nulerror #22

Closed

Force1ess wants to merge 1 commit into messense:main from Force1ess:main

Force1ess commented Jan 7, 2024

fix nulerror by replace '\0'
maybe we should consider function signatures
all tests pass on my mac


          fix nulerror

Owner

messense commented Jan 7, 2024

Thanks for the PR.

IMO replacing \0 to empty string doesn't look like a clean solution, user can sanitize the input string before passing to predict.

Author

Force1ess commented Jan 10, 2024 •

edited

Loading

It's true, maybe we should add a warning to the doc

Force1ess closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet