Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send zero-datetime (0001-01-01T00:00:00Z) if not set #108

Merged
merged 3 commits into from
Jul 12, 2022

Conversation

iivvoo
Copy link

@iivvoo iivvoo commented Jul 7, 2021

We noticed that voicemessages take very long to send (up to 40sec), while a plain curl invocation will almost call immediately.
It seems to be the way the api deals with the default zero datetime, which will default to 0001-01-01T00:00:00Z.

It lacks the IsZero check that's present in the sms package, for example

@iivvoo
Copy link
Author

iivvoo commented Jul 12, 2021

To clarify a bit further, it seems the backend will always schedule voicemessages with a ScheduledDateTime, even if it's in the past or within seconds in the future, and these tasks are picked up after > 30sec.

The only way to immediately send the voicemessage is to not specify a ScheduledDateTime (or possibly send a null)

Without this fix, sending messages immediately is not possible, which is really annoying for OTP purposes

@iivvoo
Copy link
Author

iivvoo commented May 25, 2022

@messagebird thanks for ignoring this PR for nearly a year already. Truely appreciated, very professional

@iivvoo
Copy link
Author

iivvoo commented Jul 10, 2022

@messagebird congrats on ignoring my bug-fixing PR for a whole year! You really know how to make customers and developers happy! 😂

@iivvoo
Copy link
Author

iivvoo commented Jul 12, 2022

@rfeiner I fixed the (by now) broken/outdated test.

@rfeiner rfeiner merged commit a7c4534 into messagebird:master Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants