Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use v1beta1 API for credential provider API #9

Merged
merged 1 commit into from
Nov 14, 2022
Merged

feat: Use v1beta1 API for credential provider API #9

merged 1 commit into from
Nov 14, 2022

Conversation

jimmidyson
Copy link
Contributor

No description provided.

@jimmidyson jimmidyson requested a review from dkoshkin November 12, 2022 15:20
@jimmidyson jimmidyson enabled auto-merge (squash) November 12, 2022 15:21
@dkoshkin
Copy link
Contributor

Should we also change it in https://github.com/mesosphere/kubelet-image-credential-provider-shim/blob/8c3e69a651cc4d10389d3bbb38d20a3e3f1e3f30/pkg/credentialprovider/plugin.go#L18?

@jimmidyson
Copy link
Contributor Author

Updated v1beta1 API in #8 PR

@jimmidyson jimmidyson closed this Nov 14, 2022
auto-merge was automatically disabled November 14, 2022 17:32

Pull request was closed

@jimmidyson jimmidyson reopened this Nov 14, 2022
@jimmidyson jimmidyson merged commit 7c94b9f into main Nov 14, 2022
@jimmidyson jimmidyson deleted the jimmi/demo-v1beta1 branch November 14, 2022 21:15
@github-actions github-actions bot mentioned this pull request Nov 14, 2022
Closed
@github-actions github-actions bot mentioned this pull request Dec 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoshkin dkoshkin dkoshkin approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmidyson @dkoshkin