Add macOS linker versioning information #3358
Conversation
|
@jpakkane As requested... |
mesonbuild/compilers/compilers.py
Outdated
| @@ -902,14 +902,15 @@ def thread_flags(self, env): | |||
| ICC_OSX = 1 | |||
| ICC_WIN = 2 | |||
|
|
|||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
[Flake8]
[E227] missing whitespace around bitwise or shift operator
mesonbuild/compilers/compilers.py
Outdated
| @@ -902,14 +902,15 @@ def thread_flags(self, env): | |||
| ICC_OSX = 1 | |||
| ICC_WIN = 2 | |||
|
|
|||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
[Flake8]
[E999] SyntaxError: invalid syntax
mesonbuild/compilers/compilers.py
Outdated
| @@ -902,14 +902,15 @@ def thread_flags(self, env): | |||
| ICC_OSX = 1 | |||
| ICC_WIN = 2 | |||
|
|
|||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
[Flake8]
[E225] missing whitespace around operator
This patch exploits the information residing in ltversion to set the -compatibility_version and -current_version flags that are passed to the linker on macOS.
tschoonj
force-pushed
the
macos-versioning-fix-2
branch
from
23ef07c to
25c302d
Compare
| major = int(splitted[0]) | ||
| minor = int(splitted[1]) | ||
| revision = int(splitted[2]) | ||
| args += ['-compatibility_version', '%d' % (major + minor + 1)] |
There was a problem hiding this comment.
This seems a bit baffling. It would mean that versions 1.2.3 and 2.1.3 would get the same compatibility version. Is that really what should happen? Is there a link to Apple's documentation that says what this should do? I tried looking some time ago but the docs I found were most unhelpful.
There was a problem hiding this comment.
They would indeed have the same compatibility_version, but a different soversion, which is why this works.
Have a look at SharedLibrary::process_kwargs:
elif self.ltversion:
# library version is defined, get the soversion from that
# We replicate what Autotools does here and take the first
# number of the version by default.
self.soversion = self.ltversion.split('.')[0]
|
From my limited understanding of library versioning on OSX this seems reasonable. Anyone with more experience want to comment? @nirbheek? |
|
After discussing with @ePirat it looks like we merged this PR incorrectly. This means that at best, we can set it to It is going to be very confusing if we version libraries on Linux in one way and on macOS using another way. We should revert this PR. |
This patch exploits the information residing in ltversion to set the
-compatibility_version and -current_version flags that are passed to the
linker on macOS.
This PR contains part of the patch found in #2577