dependencies/jni: Properly resolve jni dependency on android #14225
Conversation
The NDK has a jni.h in sysroot/usr/include/, there are no extra native modules that provide any callable symbols.
| if 'version' in kwargs: | ||
| mlog.error('Can\'t set version filter for jni on Android') | ||
| self.is_found = False | ||
| return |
There was a problem hiding this comment.
I think these need to be if kwargs.get('version'): because they may get set to None or [] in some paths.
I guess the version can't be found without actually compiling something here, since jni.h doesn't have any versions in it.
I think for version I'd prefer a warning rather than an exception, since this prevents someone from having code that runs on Android and !Android without doing extra work. So instead of users having to deal with that, just doing the:
mlog.debug("Android does not provide a mechanism to test the version of JNI, version restrictions are ignored")Is a better solution. Also just debug for the debug log, because it's not an actionable item.
| self.is_found = False | ||
| return | ||
| if 'modules' in kwargs: | ||
| mlog.error('Can\'t depend on jni modules on Android') |
There was a problem hiding this comment.
maybe: "Android does not provide JNI modules"
I'm also not sure that this is a good place for an error. I'm trying to decide if I think warning or debug is better
I'm unhappy with the error messages, please suggest better ones