Share dependency implementaiton between dependency and python.installation.dependency
#14199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we're going to have None once we move to more typed_kwargs
We're going to use this in the Python module as well.
Otherwise we run into issues where the key doesn't match when some values are empty and others are not.
dcbaker
force-pushed
the
submit/dependency-share-implementation
branch
from
cf4854a to
0af7113
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second reduced series from #13995.
This small series the function annotations are brought in line with the existing typed_kwargs call, and the dependency kwargs are moved to a shared location so the python dependency can share them.
This also attempts to handle one of the issues that has vexed me about this work, which is keeping a single source of truth for the IR classes. The interpreter provides defaults for all arguments, all the time. We also have defaults in the IR initializers, which means there's a moving source of truth (just look at
CustomTarget). I've attempted to solve this by using the sharedDEPENDENCY_KWSto fill in default values for dependency, which gives us a single source of truth. It does lead to a bit of ugly imports, but I like the result.