Add new targets to run rustfmt for Rust projects #13932
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonzini
force-pushed
the
rustfmt
branch
2 times, most recently
from
ed847b1 to
ebb433c
Compare
|
Rebased on top of the updated #13914. |
bonzini
force-pushed
the
rustfmt
branch
3 times, most recently
from
d732c1f to
3ae4a45
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| from ..mesonlib import MachineChoice | ||
|
|
||
| if T.TYPE_CHECKING: | ||
| from ..compilers.rust import RustCompiler |
Check notice
Code scanning / CodeQL
Unused import Note
dcbaker
requested changes
Dec 19, 2024
Signed-off-by: Paolo Bonzini <[email protected]>
dcbaker
requested changes
Dec 19, 2024
This is very similar to clippy, with different command line of course. Also it can change files, so do not run it twice on the same file. Signed-off-by: Paolo Bonzini <[email protected]>
dcbaker
approved these changes
Dec 19, 2024
|
Moving to draft because it doesn't work with structured sources. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the existing targets invoking clang-format, this PR adds two targets rustfmt and rustfmt-check that invoke rustfmt.
The basic logic is the same as for clippy, including reusing the updated run_tool infrastructure and the RustCompiler.get_rust_tool method.