CI: fix macos unbreaking python #13136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qt4 doesn't seem to work on Apple Silicon because OpenSSL 1.0 (a requirement for Qt4) doesn't build on it correctly, trying to use X86 assembly.
dcbaker
force-pushed
the
submit/fix-macos-ci
branch
3 times, most recently
from
24effad to
de00a80
Compare
tristan957
approved these changes
Apr 25, 2024
dcbaker
force-pushed
the
submit/fix-macos-ci
branch
from
de00a80 to
4eee258
Compare
homebrew installs to /usr/local on Intel based macs, but has moved to /opt/homebrew for those using Apple Silicon.
There are some additional packages that seem to be needed on Apple based Silicon.
Boost now requires C++ 14, as of 1.82
dcbaker
force-pushed
the
submit/fix-macos-ci
branch
from
85a20cd to
f3cdfda
Compare
Comment on lines
+695
to
-692
| Path('/usr/local/opt/boost'), # for Intel Silicon MacOS | ||
| ]) | ||
| tmp += [Path('/opt/local')] | ||
| tmp += [Path('/usr/local/opt/boost')] |
There was a problem hiding this comment.
This path is specific to Apple? Good to know...
There was a problem hiding this comment.
Yeah, homebrew on Intel puts its stuff there. I don't think it's a place we should necessary search automatically. I'm a little skeptical of some of the paths in there in general. Handling homebrew seems reasonable as it's pretty much de facto for Apple
On Apple Silicon the default search path is /opt/homebrew instead of /usr/local.
dcbaker
force-pushed
the
submit/fix-macos-ci
branch
from
f3cdfda to
fd65b09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The install location seems to have moved, which breaks our job to unbreak things.