Add meson test --interactive #13112
Merged
Add meson test --interactive #13112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eli-schwartz
requested changes
Apr 19, 2024
DaanDeMeyer
force-pushed
the
interactive
branch
2 times, most recently
from
1893caf to
e06fbe2
Compare
|
Let me know if I added the release notes snippet in the right file |
|
docs/markdown/snippets/*.md |
DaanDeMeyer
force-pushed
the
interactive
branch
3 times, most recently
from
20209f8 to
e61afa6
Compare
|
@jpakkane @eli-schwartz Any chance this could get another look? This is the final piece we need to allow debugging systemd's integration tests. |
jpakkane
reviewed
Apr 23, 2024
DaanDeMeyer
force-pushed
the
interactive
branch
from
e61afa6 to
61a2fd3
Compare
jpakkane
reviewed
Apr 23, 2024
DaanDeMeyer
force-pushed
the
interactive
branch
from
61a2fd3 to
40e0ef9
Compare
This is very similar to --gdb, except it doesn't spawn GDB, but connects stdin/stdout/stderr directly to the test itself. This allows interacting with integration tests that spawn a shell in a container or virtual machine when the test fails. In systemd we're migrating our integration tests to run using the meson test runner. We want to allow interactive debugging of failed tests directly in the virtual machine or container that is spawned to run the test. To make this possible, we need meson test to connect stdin/stdout/stderr of the test directly to the user's terminal, just like is done with the --gdb option.
This allows tests to check whether stdin is a tty to figure out if they're running in interactive mode or not. It also makes sure that tests that are not running in interactive mode don't inadvertendly try to read from stdin.
DaanDeMeyer
force-pushed
the
interactive
branch
from
40e0ef9 to
d68306c
Compare
|
LGTM |
tristan957
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very similar to --gdb, except it doesn't spawn GDB, but connects stdin/stdout/stderr directly to the test itself. This allows interacting with integration tests that spawn a shell in a container or virtual machine when the test fails.
In systemd we're migrating our integration tests to run using the meson test runner. We want to allow interactive debugging of failed tests directly in the virtual machine or container that is spawned to run the test. To make this possible, we need meson test to connect stdin/stdout/stderr of the test directly to the user's terminal, just like is done with the --gdb option.