ENH: adjust default build options #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm updating the documentation. I wanted to check that this does not break anything before finishing the documentation. |
|
Documentation updated. I still feel that the "Default build options" page belongs to "Reference" and not to "Explanations". I also feels that splitting the documentation is these sections is silly, but this is a longer story... |
Switch from debug=false, optimization=2 to buildtype=release. Despite what the Meson documentation says, the former does not change the default buildtype=debug, which undesired effects on other settings derived from the value of the buildtype option. Whit the default b_vscrt=from_buildtype option, Meson instructs the MSVC compiler to use the debug version of the VS runtime library when buildtype=debug. This causes the linker look for the debug build of all the linked DLLs. The Python distribution for Windows does not contain a debug version of the python.dll and linking fails. To avoid this issue when the user explicitly asks for a debug build, also set b_vscrt=mt. The b_ndebug=if-release option set by meson-python also looks at the value of the buildtype and not to the value of the debug options. Setting buildtype=release has the desired effect of disabling assertions. The prefix, python.purelibdir, and python.platlibdir build options are no more necessary after the heuristic for determining the location where installed files need to be placer from their installation location has been removed in mesonbuild#280. Remove them. Fixes mesonbuild#381.
dnicolodi
force-pushed
the
build-otpions
branch
11 times, most recently
from
e58ac01 to
9823669
Compare
|
Running the tests with MSVC bumped into a bug in Meson mesonbuild/meson#11655. I added a work around. |
rgommers
reviewed
Apr 8, 2023
There was a problem hiding this comment.
This looks pretty good, thanks @dnicolodi. One suggestion for security, and one question on --only-changed.
| '--python.purelibdir', | ||
| sys_paths['purelib'], | ||
| '--python.platlibdir', | ||
| sys_paths['platlib'], |
There was a problem hiding this comment.
I'll note that the change to --destdir and these options no longer being needed was discussed in #338 (comment). Looks like we agreed on that, and it has a good rationale.
dnicolodi
force-pushed
the
build-otpions
branch
2 times, most recently
from
dd7b4c4 to
2e98c20
Compare
The install directory is always an empty temporary directory, thus passing the --only-changed option cannot speed up installation. On the contrary, it most likely requires at least one extra stat() system call for each file copied. This option was added with the first implementation of editable installs. There the installation was performed on a permanent directory and the --only-changed option helped reducing the installation time. When meson install is run the project has been just been built, thus it is not necessary to rebuild it. Add the --no-rebuild option.
Meson assumes that a .pdb file is generated for executables also when they are compiled without debug symbols, and adds it to the installation manifest. This causes meson-python to try to add a file that does not exist to the wheel.
Allow .pyw source file extension on Windows and reject all unknown file extensions: Python package directory names cannot contain a dot.
This was referenced Apr 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from debug=false, optimization=2 to buildtype=release. Despite what the Meson documentation says, the former does not change the default buildtype=debug, which undesired effects on other settings derived from the value of the buildtype option.
Whit the default b_vscrt=from_buildtype option, Meson instructs the MSVC compiler to use the debug version of the VS runtime library when buildtype=debug. This causes the linker look for the debug build of all the linked DLLs. The Python distribution for Windows does not contain a debug version of the python.dll and linking fails. To avoid this issue when the user explicitly asks for a debug build, also set b_vscrt=mt.
The b_ndebug=if-release option set by meson-python also looks at the value of the buildtype and not to the value of the debug options. Setting buildtype=release has the desired effect of disabling assertions.
The prefix, python.purelibdir, and python.platlibdir build options are no more necessary after the heuristic for determining the location where installed files need to be placer from their installation location has been removed in #280. Remove them.
Fixes #381.