Slightly hack-y workaround for .DAE loading #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tkoolen Here's the forearm .DAE file with this PR:
|
1 task
|
OK, this seems great to me. Good to merge? |
|
I'm actually working on a better solution right now. I'm going to do the slightly harder but more correct thing of treating a mesh file as an entire Object, not just a geometry. That requires some extra work to handle .obj files (because they annoyingly store their materials in separate files), but it will make this code more correct and should mean that, for example, Valkyrie will now show up with textures. |
|
Closing in favor of #54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A step towards fixing JuliaRobotics/MeshCatMechanisms.jl#32
With this PR, I think .DAE MeshFile objects should work pretty well. The only issue is that it's possible for the user to try to specify a material in Julia for a .DAE MeshFile, but that specification will have no effect on what's rendered. I think the right fix is to not let users specify materials for MeshFiles anyway (as in JuliaRobotics/MeshCatMechanisms.jl#32 (comment) ), so this is OK on the meshcat javascript side.