-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use marked instead of mdast-util-from-markdown #5636
Conversation
This will remove 33 dependencies pulled down by mdast-util-from-markdown. marked has 0 dependencies. mermaid's dependency count will go from 102 to 69
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5636 +/- ##
==========================================
- Coverage 5.86% 5.86% -0.01%
==========================================
Files 273 274 +1
Lines 41075 41087 +12
Branches 512 488 -24
==========================================
Hits 2408 2408
- Misses 38667 38679 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
* develop: docs: fix the classDef example in stateDiagram not display as code block, and long text display overflows
There are some interesting discussions going on in the e18e Discord thread, regarding using a custom parser. So if anyone is interested in giving that a shot, we are open to it, as long as the code is not too complex / difficult to maintain. |
📑 Summary
This will remove 33 dependencies pulled down by mdast-util-from-markdown. marked has 0 dependencies.
mermaid's dependency count will go from 102 to 69
Bundle size difference
📏 Design Decisions
Dependency Graphs
Removed
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch