Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use marked instead of mdast-util-from-markdown #5636

Merged
merged 9 commits into from
Jul 16, 2024
Merged

Conversation

sidharthv96
Copy link
Member

@sidharthv96 sidharthv96 commented Jul 11, 2024

📑 Summary

This will remove 33 dependencies pulled down by mdast-util-from-markdown. marked has 0 dependencies.

Before After
image image

mermaid's dependency count will go from 102 to 69

Bundle size difference

File Previous Size New Size Difference % Change
mermaid.min.js 2.19 MB (2295094 Bytes) 2.17 MB (2271841 Bytes) 22.71 KB (-23253 Bytes) -1.02%

📏 Design Decisions

Dependency Graphs

Removed

image

📋 Tasks

Make sure you

This will remove 33 dependencies pulled down by mdast-util-from-markdown. marked has 0 dependencies.

mermaid's dependency count will go from 102 to 69
Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 8b5b1d4
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/6692b397405fd600088499dd
😎 Deploy Preview https://deploy-preview-5636--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 5.86%. Comparing base (4bb75e5) to head (8b5b1d4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #5636      +/-   ##
==========================================
- Coverage     5.86%   5.86%   -0.01%     
==========================================
  Files          273     274       +1     
  Lines        41075   41087      +12     
  Branches       512     488      -24     
==========================================
  Hits          2408    2408              
- Misses       38667   38679      +12     
Flag Coverage Δ
unit 5.86% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/mermaid/src/rendering-util/createText.ts 0.00% <0.00%> (ø)
scripts/size.ts 0.00% <0.00%> (ø)
...mermaid/src/rendering-util/handle-markdown-text.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link

argos-ci bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Jul 13, 2024, 5:16 PM

@sidharthv96 sidharthv96 requested review from knsv, aloisklink and a team July 13, 2024 12:59
* develop:
  docs: fix the classDef example in stateDiagram not display as code block, and long text display overflows
@sidharthv96
Copy link
Member Author

There are some interesting discussions going on in the e18e Discord thread, regarding using a custom parser. So if anyone is interested in giving that a shot, we are open to it, as long as the code is not too complex / difficult to maintain.

@sidharthv96 sidharthv96 added this pull request to the merge queue Jul 16, 2024
Merged via the queue into develop with commit b1b480a Jul 16, 2024
28 checks passed
@sidharthv96 sidharthv96 deleted the sidv/marked branch July 16, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants