Use v8 coverage in vitest #4560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR should resolve this issue #4554, am I right? It was a suggested solution from in this comment istanbuljs/nyc#1302 (comment). |
|
It might, but cypress is still using istanbul. |
* develop: Update docs Cleanup Clean up some spacing in examples Correct the Gantt milestones example fix(class): keep members in namespace classes
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #4560 +/- ##
===========================================
- Coverage 77.94% 77.49% -0.45%
===========================================
Files 136 137 +1
Lines 10445 16296 +5851
Branches 491 496 +5
===========================================
+ Hits 8141 12629 +4488
- Misses 2123 3567 +1444
+ Partials 181 100 -81
Flags with carried forward coverage won't be shown. Click here to find out more. |
github-merge-queue bot
referenced
this pull request
in fuxingloh/contented
Jul 2, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [mermaid](https://github.com/mermaid-js/mermaid) | [`10.2.3` -> `10.2.4`](https://renovatebot.com/diffs/npm/mermaid/10.2.3/10.2.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mermaid-js/mermaid (mermaid)</summary> ### [`v10.2.4`](https://github.com/mermaid-js/mermaid/releases/tag/v10.2.4): 10.2.4 [Compare Source](https://github.com/mermaid-js/mermaid/compare/v10.2.3...v10.2.4) #### Features - Add Plausible analytics to mermaid.js.org by [@​sidharthv96](https://github.com/sidharthv96) in [https://github.com/mermaid-js/mermaid/pull/4473](https://github.com/mermaid-js/mermaid/pull/4473) - Support for development in Docker by [@​nirname](https://github.com/nirname) in [https://github.com/mermaid-js/mermaid/pull/4478](https://github.com/mermaid-js/mermaid/pull/4478) - standardize info diagram definitions by [@​Yokozuna59](https://github.com/Yokozuna59) in [https://github.com/mermaid-js/mermaid/pull/4486](https://github.com/mermaid-js/mermaid/pull/4486) - Change C4 stereotype braces from ASCII <\</>> to Unicode «/» by [@​jonathan-r-young](https://github.com/jonathan-r-young) in [https://github.com/mermaid-js/mermaid/pull/4460](https://github.com/mermaid-js/mermaid/pull/4460) - Add coverage for E2E tests by [@​sidharthv96](https://github.com/sidharthv96) in [https://github.com/mermaid-js/mermaid/pull/4498](https://github.com/mermaid-js/mermaid/pull/4498) - set normal mode for vitest coverage by [@​Yokozuna59](https://github.com/Yokozuna59) in [https://github.com/mermaid-js/mermaid/pull/4505](https://github.com/mermaid-js/mermaid/pull/4505) - Use v8 coverage in vitest by [@​sidharthv96](https://github.com/sidharthv96) in [https://github.com/mermaid-js/mermaid/pull/4560](https://github.com/mermaid-js/mermaid/pull/4560) - feat(flowchart): add classDef style group definition by [@​tomperr](https://github.com/tomperr) in [https://github.com/mermaid-js/mermaid/pull/3923](https://github.com/mermaid-js/mermaid/pull/3923) - add cypress coverage clean by [@​Yokozuna59](https://github.com/Yokozuna59) in [https://github.com/mermaid-js/mermaid/pull/4556](https://github.com/mermaid-js/mermaid/pull/4556) - fix(class): keep members in namespace classes by [@​tomperr](https://github.com/tomperr) in [https://github.com/mermaid-js/mermaid/pull/4532](https://github.com/mermaid-js/mermaid/pull/4532) #### Bugfixes - Add hint on "flowchart" and "graph" by [@​koppor](https://github.com/koppor) in [https://github.com/mermaid-js/mermaid/pull/4096](https://github.com/mermaid-js/mermaid/pull/4096) - fix(flowchart): apply style on doublecircle by [@​tomperr](https://github.com/tomperr) in [https://github.com/mermaid-js/mermaid/pull/4540](https://github.com/mermaid-js/mermaid/pull/4540) - fix not rendered style when style is optional by [@​Yokozuna59](https://github.com/Yokozuna59) in [https://github.com/mermaid-js/mermaid/pull/4528](https://github.com/mermaid-js/mermaid/pull/4528) - fix(flowchart): allow multiple vertices with style by [@​tomperr](https://github.com/tomperr) in [https://github.com/mermaid-js/mermaid/pull/4553](https://github.com/mermaid-js/mermaid/pull/4553) #### Documentation - change REAMDME.md coverage from coveralls into codecov by [@​Yokozuna59](https://github.com/Yokozuna59) in [https://github.com/mermaid-js/mermaid/pull/4507](https://github.com/mermaid-js/mermaid/pull/4507) - Update latest news section by [@​huynhicode](https://github.com/huynhicode) in [https://github.com/mermaid-js/mermaid/pull/4468](https://github.com/mermaid-js/mermaid/pull/4468) - Fix link to Tutorials from n00b-overview page by [@​Spiderpig86](https://github.com/Spiderpig86) in [https://github.com/mermaid-js/mermaid/pull/4472](https://github.com/mermaid-js/mermaid/pull/4472) - Fix Directives Documentation by [@​adamazing](https://github.com/adamazing) in [https://github.com/mermaid-js/mermaid/pull/4475](https://github.com/mermaid-js/mermaid/pull/4475) - Correct "Bronze" spelling in timeline docs by [@​adamazing](https://github.com/adamazing) in [https://github.com/mermaid-js/mermaid/pull/4467](https://github.com/mermaid-js/mermaid/pull/4467) - Document recommended file extension and MIME type docs by [@​bollwyvl](https://github.com/bollwyvl) in [https://github.com/mermaid-js/mermaid/pull/4485](https://github.com/mermaid-js/mermaid/pull/4485) - Fix typo in quadrant chart documentation by [@​tobie](https://github.com/tobie) in [https://github.com/mermaid-js/mermaid/pull/4512](https://github.com/mermaid-js/mermaid/pull/4512) - fix cspell issues in \*.md files by [@​Yokozuna59](https://github.com/Yokozuna59) in [https://github.com/mermaid-js/mermaid/pull/4531](https://github.com/mermaid-js/mermaid/pull/4531) - docs: Howto on foreground color on timelines by [@​mcbeelen](https://github.com/mcbeelen) in [https://github.com/mermaid-js/mermaid/pull/4524](https://github.com/mermaid-js/mermaid/pull/4524) - Add citation.cff file by [@​schackartk](https://github.com/schackartk) in [https://github.com/mermaid-js/mermaid/pull/4521](https://github.com/mermaid-js/mermaid/pull/4521) - Update Tutorials.md by [@​ellenealds](https://github.com/ellenealds) in [https://github.com/mermaid-js/mermaid/pull/4539](https://github.com/mermaid-js/mermaid/pull/4539) - Add Standard Notes extension in integrations page by [@​nienow](https://github.com/nienow) in [https://github.com/mermaid-js/mermaid/pull/4557](https://github.com/mermaid-js/mermaid/pull/4557) - Fix up Gantt Chart demo by [@​AlexMooney](https://github.com/AlexMooney) in [https://github.com/mermaid-js/mermaid/pull/4561](https://github.com/mermaid-js/mermaid/pull/4561) #### Chore - Update all patch dependencies (patch) by [@​renovate](https://github.com/renovate) in [https://github.com/mermaid-js/mermaid/pull/4482](https://github.com/mermaid-js/mermaid/pull/4482) - chore: revise Contributing documentation by [@​weedySeaDragon](https://github.com/weedySeaDragon) in [https://github.com/mermaid-js/mermaid/pull/3814](https://github.com/mermaid-js/mermaid/pull/3814) - chore(deps): update all minor dependencies (minor) by [@​renovate](https://github.com/renovate) in [https://github.com/mermaid-js/mermaid/pull/4435](https://github.com/mermaid-js/mermaid/pull/4435) - fix(deps): update all patch dependencies (patch) by [@​renovate](https://github.com/renovate) in [https://github.com/mermaid-js/mermaid/pull/4510](https://github.com/mermaid-js/mermaid/pull/4510) - fix(deps): update all patch dependencies (patch) by [@​renovate](https://github.com/renovate) in [https://github.com/mermaid-js/mermaid/pull/4535](https://github.com/mermaid-js/mermaid/pull/4535) - chore(deps): update dependency eslint-plugin-jsdoc to v46 by [@​renovate](https://github.com/renovate) in [https://github.com/mermaid-js/mermaid/pull/4544](https://github.com/mermaid-js/mermaid/pull/4544) - chore(deps): update dependency jsdom to v22 by [@​renovate](https://github.com/renovate) in [https://github.com/mermaid-js/mermaid/pull/4546](https://github.com/mermaid-js/mermaid/pull/4546) - chore(deps): update dependency eslint-plugin-unicorn to v47 by [@​renovate](https://github.com/renovate) in [https://github.com/mermaid-js/mermaid/pull/4545](https://github.com/mermaid-js/mermaid/pull/4545) - chore(deps): update dependency workbox-window to v7 by [@​renovate](https://github.com/renovate) in [https://github.com/mermaid-js/mermaid/pull/4547](https://github.com/mermaid-js/mermaid/pull/4547) - chore(deps): update node.js to v20 by [@​renovate](https://github.com/renovate) in [https://github.com/mermaid-js/mermaid/pull/4548](https://github.com/mermaid-js/mermaid/pull/4548) - fix(deps): update all patch dependencies (patch) by [@​renovate](https://github.com/renovate) in [https://github.com/mermaid-js/mermaid/pull/4543](https://github.com/mermaid-js/mermaid/pull/4543) - add `Suggested Solutions` field in `bug_report.yml` by [@​Yokozuna59](https://github.com/Yokozuna59) in [https://github.com/mermaid-js/mermaid/pull/4541](https://github.com/mermaid-js/mermaid/pull/4541) #### New Contributors - [@​Spiderpig86](https://github.com/Spiderpig86) made their first contribution in [https://github.com/mermaid-js/mermaid/pull/4472](https://github.com/mermaid-js/mermaid/pull/4472) - [@​adamazing](https://github.com/adamazing) made their first contribution in [https://github.com/mermaid-js/mermaid/pull/4475](https://github.com/mermaid-js/mermaid/pull/4475) - [@​koppor](https://github.com/koppor) made their first contribution in [https://github.com/mermaid-js/mermaid/pull/4096](https://github.com/mermaid-js/mermaid/pull/4096) - [@​nirname](https://github.com/nirname) made their first contribution in [https://github.com/mermaid-js/mermaid/pull/4478](https://github.com/mermaid-js/mermaid/pull/4478) - [@​Yokozuna59](https://github.com/Yokozuna59) made their first contribution in [https://github.com/mermaid-js/mermaid/pull/4486](https://github.com/mermaid-js/mermaid/pull/4486) - [@​jonathan-r-young](https://github.com/jonathan-r-young) made their first contribution in [https://github.com/mermaid-js/mermaid/pull/4460](https://github.com/mermaid-js/mermaid/pull/4460) - [@​tobie](https://github.com/tobie) made their first contribution in [https://github.com/mermaid-js/mermaid/pull/4512](https://github.com/mermaid-js/mermaid/pull/4512) - [@​schackartk](https://github.com/schackartk) made their first contribution in [https://github.com/mermaid-js/mermaid/pull/4521](https://github.com/mermaid-js/mermaid/pull/4521) - [@​mcbeelen](https://github.com/mcbeelen) made their first contribution in [https://github.com/mermaid-js/mermaid/pull/4524](https://github.com/mermaid-js/mermaid/pull/4524) - [@​ellenealds](https://github.com/ellenealds) made their first contribution in [https://github.com/mermaid-js/mermaid/pull/4539](https://github.com/mermaid-js/mermaid/pull/4539) - [@​nienow](https://github.com/nienow) made their first contribution in [https://github.com/mermaid-js/mermaid/pull/4557](https://github.com/mermaid-js/mermaid/pull/4557) - [@​AlexMooney](https://github.com/AlexMooney) made their first contribution in [https://github.com/mermaid-js/mermaid/pull/4561](https://github.com/mermaid-js/mermaid/pull/4561) **Full Changelog**: mermaid-js/mermaid@v10.2.3...v10.2.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/levaintech/contented). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNDQuMiIsInVwZGF0ZWRJblZlciI6IjM1LjE0NC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
Use v8 as coverage provider instead of istanbul in vitest to improve accuracy.
Resolves #4554
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
📋 Tasks
Make sure you
developbranch