-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gantt test broken #4198
Comments
@aloisklink possibly related to dayjs? But not sure why the behaviour is different between v9 & v10 |
I just ran Cypress on commit 06640ab (aka the one right before a5db04b, where we added
The only e2e test snapshot that changed in the switch to By the way, we should probably make something like a The OpenWRT repo is a good example, since they are always committing backports: https://github.com/openwrt/openwrt |
Hmmmm, apparently the today marker isn't there. Even when I changed See below for an actual working test: ```mermaid
gantt
title todayMarker on
dateFormat YYYY-MM-DD
axisFormat %d
todayMarker on
section Section1
Today: 2023-03-08, -1h
The future: 2025-01-01
``` gantt
title todayMarker on
dateFormat YYYY-MM-DD
axisFormat %d
todayMarker on
section Section1
Today: 2023-03-08, -1h
The future: 2025-01-01
And the same diagram with gantt
title todayMarker off
dateFormat YYYY-MM-DD
axisFormat %d
todayMarker off
section Section1
Today: 2023-03-08, -1h
The future: 2025-01-01
|
The gantt diagram that were supposed to test whether `todayMarker off` works wasn't working properly, because `todayMarker on` wasn't working (i.e. the test never failed). I've fixed this issue, and added a test that checks whether `todayMarker on` works. Fixes: mermaid-js#4198
Description
In 9.4.2
In 10
demo says line should be invisible, but it's visible.
Steps to reproduce
Screenshots
No response
Code Sample
No response
Setup
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: