Add a Gitter chat badge to README.md #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rting when initializing ng-grid
… existing code only tests for the existence of a noSortVisible function. we should be executing the function.
Improved german translation
…inning fixes angular-ui#380 angular-ui#241: column reordering not working if pinning enabled
It will be great to have opportunity to set custom "cellEditTemplate"
Update column.js
Fixed Leave Field behaviour when "enableCellEdit" is set as column parameter
Update ng-input.js
…sort operation. The renderedRange was incorrectly being set to the whole of the source data.
Fixed issue where clearing the filter is slow after a sort operation. T...
…ested_objs Update searchProvider to look for values in properties that come after the first object
…w count is sensible - just using a correct interpretation
…r (absent) scrollbar
Setting this option prevents tabs from being processed by the control, and are instead used to switch between controls. This makes pages more accessible because it prevents the grid from becoming a keyboard trap.
Add a new option - noTabInterference.
Second attempt to fix angular-ui#777, still ensuring the rendering row count is sensible
…c_sorting_bug 2.0.8 - fix bug for programmatic change of sortInfo
Fix row.getProperty() for numeric column names
* Only try to iterate over the properties of columnDefs.
Bug Fix (see: angular-ui#756 (comment))
Added
$scope.$emit('ngGridEventStartCellEdit');
next to
$scope.$broadcast('ngGridEventStartCellEdit');
This allows people to listen to this event.
Fixes issue with breaking changes for ngInclude in Angular 1.2.0 that broke the native column header drag&drop. See: angular/angular.js#3806 See also: angular-ui#702 Conflicts: src/classes/eventProvider.js
- keep nulls at bottom of list regardless of sort order - if user provides custom sort, allow them to have full control over sort
The calculation for newViewportHeight is off by 1px in webkit-based browsers. In cases where the actual grid height is less than the grid's max-height (even if a max-height hasn't been set) vertical-overflow scrollbars are appended to the DOM. Increasing the newViewPort by 1px corrects this issue.
The search input needs to bind to filterText for the filter to work, not fitlerOptions.filterText. PR angular-ui#513 broke this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merlinchen/ui-grid now has a Chat Room on Gitter
@merlinchen has just created a chat room. You can visit it here: https://gitter.im/merlinchen/ui-grid.
This pull-request adds this badge to your README.md:
If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.