Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unknown can be optional #7

Merged
merged 2 commits into from
Mar 26, 2020
Merged

fix: unknown can be optional #7

merged 2 commits into from
Mar 26, 2020

Conversation

eps1lon
Copy link
Contributor

@eps1lon eps1lon commented Mar 26, 2020

Fixes { value?: unknown } being considered value: PropTypes.any.isRequired.

The propTypes validator would throw runtime errors for undefined which is fine at the type-level. We want the type-level semantics at runtime.

@merceyz merceyz merged commit c5e8ca3 into merceyz:master Mar 26, 2020
@merceyz
Copy link
Owner

merceyz commented Mar 26, 2020

Thanks!

@eps1lon eps1lon deleted the fix/unknown-required branch March 26, 2020 12:16
@eps1lon eps1lon mentioned this pull request Mar 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eps1lon @merceyz