Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add redis cluster client tests #50

Merged
merged 1 commit into from
May 25, 2024

Conversation

leeym
Copy link
Collaborator

@leeym leeym commented May 23, 2024

I should have done this in #48, but I think it is not too late to do it now.

The existing test environment only has single node Redis and there is no Redis cluster.
Given that the Redis and Redis cluster may behave differently, I think we should test them separately.

  • keep Redis at port 6379 while adding Redis cluster at port 7000-7005
  • whenever we test Redis, we test Redis cluster as well

Also run it in two builds:

  • remove hash tags in redisKey to reproduce the error CROSSSLOT Keys in request don't hash to the same slot
  • add hash tags back in redisKey to show that it works

@leeym leeym force-pushed the add-redis-cluster-tests-2 branch 6 times, most recently from 8311fe6 to 5105c21 Compare May 23, 2024 07:04
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.05%. Comparing base (9d9ccea) to head (00de771).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   80.05%   80.05%           
=======================================
  Files          12       12           
  Lines        1449     1449           
=======================================
  Hits         1160     1160           
  Misses        212      212           
  Partials       77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leeym leeym force-pushed the add-redis-cluster-tests-2 branch from 5105c21 to 00de771 Compare May 23, 2024 07:16
@mennanov mennanov merged commit 87e5820 into mennanov:master May 25, 2024
9 checks passed
@mennanov
Copy link
Owner

Awesome! Thanks!

@leeym leeym deleted the add-redis-cluster-tests-2 branch May 29, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants