add TestConcurrentBufferDuplicateKeys #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #35 +/- ##
==========================================
- Coverage 83.51% 83.46% -0.05%
==========================================
Files 10 10
Lines 1468 1464 -4
==========================================
- Hits 1226 1222 -4
Misses 169 169
Partials 73 73 ☔ View full report in Codecov by Sentry. |
leeym
force-pushed
the
add-TestConcurrentBufferDuplicateKeys
branch
from
2a24455 to
0307a95
Compare
leeym
force-pushed
the
add-TestConcurrentBufferDuplicateKeys
branch
2 times, most recently
from
c75be95 to
c5aa874
Compare
mennanov
approved these changes
Feb 29, 2024
|
Feel free to merge when ready |
leeym
force-pushed
the
add-TestConcurrentBufferDuplicateKeys
branch
from
c5aa874 to
4445182
Compare
It looks like I don't have write access to merge it. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new test TestConcurrentBufferDuplicateKeys and fix ConcurrenfBufferMemcached to make sure it follows the other implementations to actually act as a set and handle duplicates correctly.