Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for RHEL8.8 #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

slack2450
Copy link
Contributor

No description provided.

@slack2450
Copy link
Contributor Author

It would be worth testing on a machine that isn't redhat to make sure this doesn't cause issues

@h33p
Copy link
Member

h33p commented Aug 2, 2023

I don't quite trust this mechanism working really well, because it is not clear which older versions it was backported to. I think ideal thing to check would be existence of mmap_lock.h file:

$ grep -r "mmap_write_lock" /lib/modules/$(uname -r)/source          
/lib/modules/6.2.9-200.fc37.x86_64/source/include/linux/mmu_notifier.h: mmap_write_lock(mm);
/lib/modules/6.2.9-200.fc37.x86_64/source/include/linux/mmap_lock.h:static inline void mmap_write_lock(struct mm_struct *mm)
/lib/modules/6.2.9-200.fc37.x86_64/source/include/linux/mmap_lock.h:static inline void mmap_write_lock_nested(struct mm_struct *mm, int subclass)
/lib/modules/6.2.9-200.fc37.x86_64/source/include/linux/mmap_lock.h:static inline int mmap_write_lock_killable(struct mm_struct *mm)

Could you check for existence of the file in the Makefile and define a variable, something like HAS_MMAP_LOCK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants