Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add end of pipe clean up hook to Sinks #750

Merged
merged 8 commits into from
Jun 24, 2022
Merged

feat: Add end of pipe clean up hook to Sinks #750

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
485ddf8
add clean up hook to sinks called at end of pipe drain
z3z1ma Jun 22, 2022
42d17f2
make message more clear for devs and add decorator
z3z1ma Jun 23, 2022
6118a9f
unwrap the comprehension so mypy doesnt get mad
z3z1ma Jun 23, 2022
3c5fa09
remove abstract method
z3z1ma Jun 23, 2022
3645495
Merge branch 'meltano:main' into clean_up_hook
z3z1ma Jun 24, 2022
714f760
fix flake8 errors
z3z1ma Jun 24, 2022
24d9853
Merge branch 'clean_up_hook' of https://github.com/z3z1ma/sdk into cl…
z3z1ma Jun 24, 2022
442ccc7
Merge branch 'main' into clean_up_hook
edgarrmondragon Jun 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove abstract method
  • Loading branch information
@z3z1ma
z3z1ma committed Jun 23, 2022
commit 3c5fa09fdd757a4eaccdd8da22a4bf528e87ebd9
1 change: 0 additions & 1 deletion singer_sdk/sinks/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,6 @@ def activate_version(self, new_version: int) -> None:
"Ignoring."
)

@abc.abstractmethod
def clean_up(self) -> None:
"""Perform any clean up actions required at end of a stream.

Expand Down