-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Require uv be used with Nox #2866
Conversation
Reviewer's Guide by SourceryThis pull request enforces the use of uv as the virtual environment backend for Nox, updates CI to use uv for installing Nox and setting up the environment, and removes pip upgrades. Flow diagram: Updated CI Environment Setup Processflowchart TD
A[Start CI Job] --> B[Setup Python]
B --> C[Setup uv v0.5.26]
C --> D[Install Nox using uv]
D --> E[Run Nox sessions]
style C fill:#90EE90
style D fill:#90EE90
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2866 +/- ##
=======================================
Coverage 91.34% 91.34%
=======================================
Files 62 62
Lines 5209 5209
Branches 673 673
=======================================
Hits 4758 4758
Misses 319 319
Partials 132 132 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #2866 will not alter performanceComparing Summary
|
82b1601
to
a7c82a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @edgarrmondragon - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
* chore: Require uv be used with Nox * Use uv more broadly * Move `UV_CONSTRAINT` to the top * Remove redundant installation of griffe
* chore: Require uv be used with Nox * Use uv more broadly * Move `UV_CONSTRAINT` to the top * Remove redundant installation of griffe
* chore: Require uv be used with Nox * Use uv more broadly * Move `UV_CONSTRAINT` to the top * Remove redundant installation of griffe
Summary by Sourcery
Require the use of
uv
for virtual environment management in Nox sessions and across all GitHub Actions workflows.Build:
uv tool install
instead ofpipx
.pip
from dependencies and constraints.CI:
uv
to manage virtual environments in GitHub Actions workflows.UV_CONSTRAINT
environment variable to the project's requirements file.UV_VERSION
environment variable to 0.5.26.setup-uv
action to set upuv
.📚 Documentation preview 📚: https://meltano-sdk--2866.org.readthedocs.build/en/2866/