-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert: Add back some upper Python version constraints in dependencies #2858
Conversation
Reviewer's Guide by SourceryThis pull request reverts a previous commit that introduced upper version constraints on some dependencies. The constraints have been removed, allowing for more flexibility in dependency management. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @edgarrmondragon - I've reviewed your changes - here's some feedback:
Overall Comments:
- Adding Python 4 version constraints seems premature since Python 4 doesn't exist yet. Consider keeping the more permissive version constraints from the previous commit unless there's a specific compatibility concern.
- There appears to be a typo in the flake8-datetimez comment (changed to 'datetimezs')
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2858 +/- ##
=======================================
Coverage 91.34% 91.34%
=======================================
Files 62 62
Lines 5209 5209
Branches 673 673
=======================================
Hits 4758 4758
Misses 319 319
Partials 132 132 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #2858 will not alter performanceComparing Summary
|
This reverts commit 7529cbf.
Causing issues for Poetry-managed downstream packages: https://github.com/meltano/sdk/actions/runs/13075031342/job/36484997547?pr=2857