Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Make PyJWT and cryptography dependencies optional #2525

Merged
merged 4 commits into from
Jul 11, 2024
Merged

refactor!: Make PyJWT and cryptography dependencies optional #2525

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5e52ca
chore!: Make `PyJWT` and `cryptography` dependencies optional
edgarrmondragon May 9, 2024
18c392c
Merge branch 'main' into edgarrmondragon/break/crypto-deps-optional
edgarrmondragon Jul 10, 2024
c396b6e
Catch exception when jwt deps are missing
edgarrmondragon Jul 10, 2024
3272f6e
Add `pragma: no cover
edgarrmondragon Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add `pragma: no cover
  • Loading branch information
@edgarrmondragon
edgarrmondragon committed Jul 10, 2024
commit 3272f6e9c0bbe38cc48b277bd6306ca338ef456e
4 changes: 2 additions & 2 deletions singer_sdk/authenticators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,11 +575,11 @@ def oauth_request_payload(self) -> dict:
import jwt # noqa: PLC0415
from cryptography.hazmat.backends import default_backend # noqa: PLC0415
from cryptography.hazmat.primitives import serialization # noqa: PLC0415
except ModuleNotFoundError as ex:
except ModuleNotFoundError as ex: # pragma: no cover
msg = "Install singer-sdk[jwt] to use OAuthJWTAuthenticator."
raise RuntimeError(msg) from ex

if not self.private_key:
if not self.private_key: # pragma: no cover
msg = "Missing 'private_key' property for OAuth payload."
raise ValueError(msg)

Expand Down
Loading