Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove legacy tap and target test helpers #2207

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jan 31, 2024

Closes #1354


📚 Documentation preview 📚: https://meltano-sdk--2207.org.readthedocs.build/en/2207/

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf03f0e) 88.46% compared to head (bbbc5c3) 88.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v1    #2207      +/-   ##
==========================================
+ Coverage   88.46%   88.52%   +0.06%     
==========================================
  Files          54       54              
  Lines        4716     4664      -52     
  Branches      917      909       -8     
==========================================
- Hits         4172     4129      -43     
+ Misses        383      377       -6     
+ Partials      161      158       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jan 31, 2024

CodSpeed Performance Report

Merging #2207 will not alter performance

Comparing edgarrmondragon/refactor/drop-legacy-tests (bbbc5c3) with v1 (bf03f0e)

Summary

✅ 6 untouched benchmarks

@edgarrmondragon edgarrmondragon marked this pull request as ready for review January 31, 2024 14:47
@edgarrmondragon edgarrmondragon merged commit 09e278e into v1 Jan 31, 2024
53 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/refactor/drop-legacy-tests branch January 31, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant